From owner-freebsd-current@FreeBSD.ORG Sat Jun 25 21:45:09 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3E6E16A41C for ; Sat, 25 Jun 2005 21:45:09 +0000 (GMT) (envelope-from pho@holm.cc) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.FreeBSD.org (Postfix) with SMTP id 61B8E43D1F for ; Sat, 25 Jun 2005 21:45:09 +0000 (GMT) (envelope-from pho@holm.cc) Received: (qmail 91526 invoked from network); 25 Jun 2005 21:45:06 -0000 Received: from unknown (HELO peter.osted.lan) (unknown) by unknown with SMTP; 25 Jun 2005 21:45:06 -0000 X-pair-Authenticated: 80.161.118.233 Received: from peter.osted.lan (localhost.osted.lan [127.0.0.1]) by peter.osted.lan (8.13.1/8.13.1) with ESMTP id j5PLj6j8025633; Sat, 25 Jun 2005 23:45:06 +0200 (CEST) (envelope-from pho@peter.osted.lan) Received: (from pho@localhost) by peter.osted.lan (8.13.1/8.13.1/Submit) id j5PLj3N8025632; Sat, 25 Jun 2005 23:45:03 +0200 (CEST) (envelope-from pho) Date: Sat, 25 Jun 2005 23:45:03 +0200 From: Peter Holm To: Mike Silbersack Message-ID: <20050625214503.GA25550@peter.osted.lan> References: <20050624212729.C537@odysseus.silby.com> <20050625133052.GA23599@peter.osted.lan> <1437.64.215.82.94.1119717536.squirrel@webmail2.pair.com> <20050625173217.GA24306@peter.osted.lan> <2565.64.215.82.94.1119729121.squirrel@webmail1.pair.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2565.64.215.82.94.1119729121.squirrel@webmail1.pair.com> User-Agent: Mutt/1.4.2.1i Cc: current@freebsd.org, Thierry Herbelot Subject: Re: Mbuf double-free guilty party detection patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2005 21:45:09 -0000 On Sat, Jun 25, 2005 at 03:52:01PM -0400, Mike Silbersack wrote: > > On Sat, Jun 25, 2005 at 12:38:56PM -0400, Mike Silbersack wrote: > >> > x.123e:This memory last freed by: 0xc2fa6c00 > >> > x.123e-panic: Memory modified after free 0xc2fa6a00(256) val=c2fa6c00 > > (kgdb) x/40x 0xc2fa6a00 > > 0xc2fa6a00: 0xc2fa6c00 0x00000000 0xc24b1ae0 0x00000520 > > I'm going to have to doublecheck my patch when I get home - the address > returned by "This memory last freed by" should be a pointer to a function > address, not a piece of data. > > So that we get more results, why don't you change the panic in trash_ctor > to a printf, then you can continue to run tests and see how many mbufs are > being corrupted without the issue of having to reboot after a panic, etc. > > Mike "Silby" Silbersack Maybe a panic is better: I got quite a few before I had to reset the box: 71 This memory last freed by: 0 18 This memory last freed by: 0x800 17 This memory last freed by: 0xdeadc0df 17 This memory last freed by: 0x1 I also added a backtrace and here's the high score: 32 tcp_output(c1e4e564) at tcp_output+0xa42 32 tcp_input(c1a1fc00,14,c1a1fc00,0,0) at tcp_input+0x2b0f 32 ip_input(c1a1fc00) at ip_input+0x511 29 vm_pageout_scan(2,c09ab0c0,0,c086e990,5c3) at vm_pageout_scan+0x107 -- Peter Holm