From owner-svn-src-all@FreeBSD.ORG Tue Jan 20 05:19:27 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 381C2B92; Tue, 20 Jan 2015 05:19:27 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E705522E; Tue, 20 Jan 2015 05:19:26 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 77D501FE023; Tue, 20 Jan 2015 06:19:24 +0100 (CET) Message-ID: <54BDE58F.3070909@selasky.org> Date: Tue, 20 Jan 2015 06:20:15 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 05:19:27 -0000 On 01/20/15 06:04, Adrian Chadd wrote: > On 19 January 2015 at 20:30, Hans Petter Selasky wrote: >> On 01/19/15 22:59, Adrian Chadd wrote: >>> >>> Hi, >>> >>> Would you please check what the results of this are with CPU specific >>> callwheels? >>> >>> I'm doing some 10+ gig traffic testing on -HEAD with RSS enabled (on >>> ixgbe) and with this setup, the per-CPU TCP callwheel stuff is >>> enabled. But all the callwheels are now back on clock(0) and so is the >>> lock contention. :( >>> >>> Thanks, >>> >> >> Hi, >> >> Like stated in the manual page, callout_reset_curcpu/on() does not work with >> MPSAFE callouts any more! > > Hm! > Hi Adrian, > How many places in the kernel did you leave like this? :P :-) > > I mean, I'm glad to have stuff be forced to be cleaned up, but you > didn't even leave a KASSERT or a debug warning that something > unsupported is being done. I'm sure I'm not going to be the first > person to be caught out like this. MPSAFE is still valid and fully useable and can be used with callout_reset_curcpu/on(), but the callout CPU will remain at zero. There is no need for a KASSERT() yet. > >> You need to use callout_init_{mtx,rm,rw} and remove the custom locking >> inside the callback in the TCP stack to get it working like before! > > Would you please give me a hand with this? I've sunk a lot of (unpaid, > personal) spare time into getting the RSS stuff into shape and now a > lot of it just plainly doesn't do anything. :( I'll send you a patch in an hours time from now for 11-current. This should be fairly trivial and then you can test and review it! --HPS