From owner-freebsd-bugs@FreeBSD.ORG Sat May 17 18:05:55 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 35DB8106567D; Sat, 17 May 2008 18:05:55 +0000 (UTC) (envelope-from anholt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 248FC8FC16; Sat, 17 May 2008 18:05:54 +0000 (UTC) (envelope-from anholt@FreeBSD.org) Received: from freefall.freebsd.org (anholt@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4HI5sfK034909; Sat, 17 May 2008 18:05:54 GMT (envelope-from anholt@freefall.freebsd.org) Received: (from anholt@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4HI5soP034905; Sat, 17 May 2008 18:05:54 GMT (envelope-from anholt) Date: Sat, 17 May 2008 18:05:54 GMT Message-Id: <200805171805.m4HI5soP034905@freefall.freebsd.org> To: anholt@freebsd.org, anholt@FreeBSD.org, freebsd-bugs@FreeBSD.org From: anholt@FreeBSD.org Cc: Subject: Re: kern/102760: [iwi] iwi firmware load fails after significant uptime X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 May 2008 18:05:55 -0000 Synopsis: [iwi] iwi firmware load fails after significant uptime State-Changed-From-To: feedback->closed State-Changed-By: anholt State-Changed-When: Sat May 17 18:04:40 UTC 2008 State-Changed-Why: I thought this had been closed. It was fixed with: commit 47b82a7f674e803139104be78d9fe2e3495be857 Author: jhb Date: Wed Mar 21 18:40:31 2007 +0000 Fix an off-by-one error in iwi_init_fw_dma(). It didn't reuse the existing DMA memory for a firmware load if it was the exact size needed, thus in the common case the driver was constantly free'ing and reallocating the DMA buffer and it would eventually begin to fail. With this fix, iwi0 reuses the same buffer the entire time and no longer fails to load the firmware after the machine has been up for a while. MFC after: 1 week http://www.freebsd.org/cgi/query-pr.cgi?pr=102760