From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 26 23:50:06 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 691171065670 for ; Sun, 26 Feb 2012 23:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 297648FC13 for ; Sun, 26 Feb 2012 23:50:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q1QNo6jl025508 for ; Sun, 26 Feb 2012 23:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q1QNo5sT025507; Sun, 26 Feb 2012 23:50:05 GMT (envelope-from gnats) Resent-Date: Sun, 26 Feb 2012 23:50:05 GMT Resent-Message-Id: <201202262350.q1QNo5sT025507@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Barney Wolff Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0839C106564A for ; Sun, 26 Feb 2012 23:48:57 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id E6DB08FC0C for ; Sun, 26 Feb 2012 23:48:56 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q1QNmuqD087489 for ; Sun, 26 Feb 2012 23:48:56 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q1QNmupn087488; Sun, 26 Feb 2012 23:48:56 GMT (envelope-from nobody) Message-Id: <201202262348.q1QNmupn087488@red.freebsd.org> Date: Sun, 26 Feb 2012 23:48:56 GMT From: Barney Wolff To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/165495: over-agressive patchfile in port www/chromium X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2012 23:50:06 -0000 >Number: 165495 >Category: ports >Synopsis: over-agressive patchfile in port www/chromium >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Feb 26 23:50:05 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Barney Wolff >Release: RELENG7 >Organization: retired >Environment: FreeBSD pit.databus.com 7.4-STABLE FreeBSD 7.4-STABLE #0: Sun Feb 26 00:44:57 EST 2012 toor@pit.databus.com:/usr/obj/usr/src/sys/PIT i386 >Description: Port www/chromium has patchfile patch-third_party__WebKit__Source__WebCore__config.h which has the test: #if __FreeBSD_version < 802502 to #define log2(x) and log2f(x). But on my 7-stable system, /usr/include/math.h has tagline: $FreeBSD: src/lib/msun/src/math.h,v 1.62.2.2 2011/10/17 05:38:22 das Exp $ which includes these functions. The result is a compiler error with both the system gcc and llvm. >How-To-Repeat: cd /usr/ports/www/chromium make all >Fix: Removed offending patchfile. But if there are really systems where it's needed, a finer-grained test should be substituted. If chromium won't run on a pre-8 system, that test belongs in the top-level Makefile. >Release-Note: >Audit-Trail: >Unformatted: