From owner-cvs-all@FreeBSD.ORG Wed May 28 20:46:09 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2C981065688; Wed, 28 May 2008 20:46:08 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206046210.chello.pl [87.206.46.210]) by mx1.freebsd.org (Postfix) with ESMTP id EA3538FC1C; Wed, 28 May 2008 20:46:07 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 2A4FA45C99; Wed, 28 May 2008 22:46:05 +0200 (CEST) Received: from localhost (chello087206046210.chello.pl [87.206.46.210]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 043C945685; Wed, 28 May 2008 22:45:58 +0200 (CEST) Date: Wed, 28 May 2008 22:45:54 +0200 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20080528204554.GA2865@garage.freebsd.pl> References: <200805261157.m4QBvnpF025029@repoman.freebsd.org> <20080526144831.K26343@fledge.watson.org> <20080526140735.GA35960@gw.reifenberger.com> <200805281309.49683.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline In-Reply-To: <200805281309.49683.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@freebsd.org, Michael Reifenberger , src-committers@freebsd.org, Robert Watson , cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/jexec jexec.8 jexec.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2008 20:46:09 -0000 --J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 28, 2008 at 01:09:49PM -0400, John Baldwin wrote: > On Monday 26 May 2008 10:07:35 am Michael Reifenberger wrote: > > On Mon, May 26, 2008 at 02:49:16PM +0100, Robert Watson wrote: > > > On Mon, 26 May 2008, Michael Reifenberger wrote: > > >=20 > > > > Extend jexec to accept hostname or ip-number besides jail-id. > > >=20 > > > It might be worth adding a caution in the man page notes somewhere th= at=20 > > > neither hostname nor IP address are guaranteed to uniquely identify a= jail=20 > > > --=20 > > > in which case, which will jexec choose? > >=20 > > I'll add some cautions to the man page. > > The jail is found by an loop through the sysctl security.jail.list > > and comparing argv against ip-number and hostname. > > The first matching jail is used then. > > Makes sense only for those who keep their jails uniquely identifyable= =20 > > by hostname or ip-number, of corse. >=20 > Maybe make it only work if it only matches a single jail? That would wor= k for=20 > the common case while avoiding ambiguities in the complex cases. Yeah. I'd also suggest to not even try to match hostnames if security.jail.set_hostname_allowed is set to 1. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --J/dobhs11T7y2rNN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIPcSAForvXbEpPzQRAiErAJ45tR2mgzXWcSwhW7Zax6ul5MCbsgCgyiWK g69RyYL3/o4rakweP6u7JVQ= =fzm+ -----END PGP SIGNATURE----- --J/dobhs11T7y2rNN--