From owner-cvs-all Sat Feb 10 2:59:27 2001 Delivered-To: cvs-all@freebsd.org Received: from njord.bart.nl (njord.bart.nl [194.158.170.15]) by hub.freebsd.org (Postfix) with ESMTP id CD44D37B491; Sat, 10 Feb 2001 02:59:02 -0800 (PST) Received: from daemon.chronias.ninth-circle.org (root@cable.ninth-circle.org [195.38.232.6]) by njord.bart.nl (8.10.1/8.10.1) with ESMTP id f1AAx0u09153; Sat, 10 Feb 2001 11:59:00 +0100 (CET) Received: (from asmodai@localhost) by daemon.chronias.ninth-circle.org (8.11.1/8.11.0) id f1AAwHd64388; Sat, 10 Feb 2001 11:58:17 +0100 (CET) (envelope-from asmodai) Date: Sat, 10 Feb 2001 11:58:16 +0100 From: Jeroen Ruigrok/Asmodai To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/monetdef af_ZA.ISO_8859-1.src da_DK.ISO_8859-1.src de_DE.ISO_8859-1.src en_AU.ISO_8859-1.src en_CA.ISO_8859-1.src en_GB.ISO_8859-1.src en_NZ.ISO_8859-1.src en_US.ISO_8859-1.src fi_FI.ISO_8859-1.src fr_CA.ISO_8859-1.src fr_FR.ISO_8859-1.src ... Message-ID: <20010210115816.C59481@daemon.ninth-circle.org> References: <200102100255.f1A2thb63857@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200102100255.f1A2thb63857@freefall.freebsd.org>; from ache@FreeBSD.org on Fri, Feb 09, 2001 at 06:55:43PM -0800 Organisation: Ninth-Circle Enterprises Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -On [20010210 04:00], Andrey A. Chernov (ache@FreeBSD.org) wrote: > Modified files: > share/monetdef af_ZA.ISO_8859-1.src da_DK.ISO_8859-1.src > de_DE.ISO_8859-1.src en_AU.ISO_8859-1.src > en_CA.ISO_8859-1.src en_GB.ISO_8859-1.src > en_NZ.ISO_8859-1.src en_US.ISO_8859-1.src > fi_FI.ISO_8859-1.src fr_CA.ISO_8859-1.src > fr_FR.ISO_8859-1.src is_IS.ISO_8859-1.src > nl_NL.ISO_8859-1.src no_NO.ISO_8859-1.src > ru_RU.KOI8-R.src sv_SE.ISO_8859-1.src > Log: > I change my mind a bit: assuming last \0 is contrproductive since will cause > user confusion, so specify it directly, i.e. change "3" to "3;0". > > In this style "3;" or "3" must not cause repeating > (converted to \3, CHAR_MAX, \0) > Still not implemented and broken in localeconv() I am not sure what you are doing. The reason it said 3;3 was to get a grouping of 3 characters after the decimal separator and then groups of 3 ad infinitum. Example: 444 444 444 444 nl_NL for example had 3;3 [which could've been written as 3 only, but specifying it as 3;3 makes more sense since the first integer had an implicit meaning of the group _immediately_ following the decimal separator] which you now changed to 3;0 and which accomplishes: 444444444 444 as far as I understood things according to the mon_grouping definitions: Defines the size of each group of digits in formatted monetary quantities. The operand is a string representing a sequence of integers separated by semicolons. Each integer specifies the number of digits in each group, with the initial integer defining the size of the group immediately preceding the decimal delimiter, and the following integers defining the preceding groups. If the last integer is not -1, then the size of the previous group (if any) is used repeatedly for the rest of the digits. If the last integer is -1, then no further grouping is performed. If not defined, mon_grouping defaults to -1 which indicates no grouping. An empty string is interpreted as -1. So, I ask you, why did you change it to 3;0 when some locales explicitely use 3;3? I might be missing something obvious... -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 We must all hang together, else we shall all hang separately... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message