From owner-svn-ports-all@FreeBSD.ORG  Tue Dec 11 03:02:51 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id AD7F2DD8; Tue, 11 Dec 2012 03:02:51 +0000 (UTC)
Date: Tue, 11 Dec 2012 03:02:51 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Tom Judge <tj@FreeBSD.org>
Subject: Re: svn commit: r308491 - in head: . textproc textproc/elasticsearch
 textproc/elasticsearch/files
Message-ID: <20121211030251.GB37200@FreeBSD.org>
References: <201212082048.qB8KmfsZ013488@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201212082048.qB8KmfsZ013488@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2012 03:02:51 -0000

On Sat, Dec 08, 2012 at 08:48:41PM +0000, Tom Judge wrote:
> New Revision: 308491
> URL: http://svnweb.freebsd.org/changeset/ports/308491
> 
> Log:
>   Elasticsearch aims to be a Distributed, RESTful, Search Engine built on
>   top of Apache Lucene.
> +# Created by:	Tom Judge <tj@FreeBSD.org>

Wrong header format (should have used space, not a tab here).  Was fixed in
r308605 by bapt@.

> +MAINTAINER=	tj@FreeBSD.org
> +COMMENT=	A full-text search engine for Java

COMMENT should not begin with an article.

> +JAVA_VERSION=	1.5+

I thought 1.5 would be deprecated soon.  Again, fixed in r308605.

> +DOCS=		LICENSE.txt \

Any reason to install LICENSE.txt file for a standard license?

> +post-patch:
> +	${SED} -i .bak -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/config/elasticsearch.yml

What's wrong with REINPLACE_CMD?  Is there necessity for global modifier in
regexp?

> +	${MKDIR} ${PREFIX}/lib/elasticsearch
> ...
> +	${MKDIR} ${PREFIX}/lib/elasticsearch/sigar

Usually MKDIR's are muted...  Also, first statement is not required as MKDIR
implies -p.

> +	@${MKDIR} ${DOCSDIR}

... Like you do here. ;-)

./danfe