From owner-svn-src-stable-7@FreeBSD.ORG Mon Oct 27 19:40:10 2008 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5135C1065670; Mon, 27 Oct 2008 19:40:10 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (unknown [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id DD81C8FC13; Mon, 27 Oct 2008 19:40:09 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 03E841CF4D; Mon, 27 Oct 2008 20:40:09 +0100 (CET) Date: Mon, 27 Oct 2008 20:40:08 +0100 From: Ed Schouten To: John Baldwin Message-ID: <20081027194008.GO6808@hoeg.nl> References: <200810262155.m9QLtJG5096815@svn.freebsd.org> <200810271422.06751.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="D3I0HgOdJ5+6n+7I" Content-Disposition: inline In-Reply-To: <200810271422.06751.jhb@freebsd.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r184300 - in stable/7/lib: libc/stdlib libutil X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2008 19:40:10 -0000 --D3I0HgOdJ5+6n+7I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * John Baldwin wrote: > I would perhaps add a note that the duplicate revoke() in openpty() is on= ly to=20 > support legacy libc's with broken unlockpt() routines. We could maybe re= move=20 > the revoke()/ptsname() from openpty() on 8.x though as all 8.x machines= =20 > should have a working unlockpt(). Good point, but I'd rather leave revoke() there for at least a couple of months. If people just download the openpty() source from -CURRENT through cvsweb and use it as an example for their own application, they could create a potential security issue when they run the application on RELENG_*. Shall we leave the revoke() call there for now, but remove it before we ship 8.0-RELEASE? --=20 Ed Schouten WWW: http://80386.nl/ --D3I0HgOdJ5+6n+7I Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkkGGRgACgkQ52SDGA2eCwXGkACdEjdPDta9QAgbe/GalVoXQNkd GagAnAi/vQe5+IqpOAIWh9rkrmv9T81p =VVa+ -----END PGP SIGNATURE----- --D3I0HgOdJ5+6n+7I--