From owner-freebsd-bugs@FreeBSD.ORG  Sat Dec  5 13:50:08 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA0081065670
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  5 Dec 2009 13:50:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B03968FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  5 Dec 2009 13:50:08 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB5Do8Og044646
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 5 Dec 2009 13:50:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB5Do8Z1044636;
	Sat, 5 Dec 2009 13:50:08 GMT (envelope-from gnats)
Date: Sat, 5 Dec 2009 13:50:08 GMT
Message-Id: <200912051350.nB5Do8Z1044636@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/139654: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2009 13:50:08 -0000

The following reply was made to PR kern/139654; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/139654: commit references a PR
Date: Sat,  5 Dec 2009 13:41:06 +0000 (UTC)

 Author: mav
 Date: Sat Dec  5 13:40:51 2009
 New Revision: 200121
 URL: http://svn.freebsd.org/changeset/base/200121
 
 Log:
   Do not ignore device interrupt if bus mastering is still active. It is
   normal in case of media read error and some ATAPI cases, when transfer size
   is unknown beforehand. PCI ATA BM specification tells that in case of such
   underrun driver should just manually stop DMA engine. DMA engine should
   same time guarantie that all bus mastering transfers completed at the moment
   of driver reads interrupt flag asserted.
   This change should fix interrupt storms and command timeouts in many cases.
   
   PR:		kern/103602, sparc64/121539, kern/133122, kern/139654
 
 Modified:
   head/sys/dev/ata/ata-pci.c
 
 Modified: head/sys/dev/ata/ata-pci.c
 ==============================================================================
 --- head/sys/dev/ata/ata-pci.c	Sat Dec  5 13:12:04 2009	(r200120)
 +++ head/sys/dev/ata/ata-pci.c	Sat Dec  5 13:40:51 2009	(r200121)
 @@ -462,8 +462,7 @@ ata_pci_status(device_t dev)
  	 (ch->dma.flags & ATA_DMA_ACTIVE))) {
  	int bmstat = ATA_IDX_INB(ch, ATA_BMSTAT_PORT) & ATA_BMSTAT_MASK;
  
 -	if ((bmstat & (ATA_BMSTAT_ACTIVE | ATA_BMSTAT_INTERRUPT)) !=
 -	    ATA_BMSTAT_INTERRUPT)
 +	if ((bmstat & ATA_BMSTAT_INTERRUPT) == 0)
  	    return 0;
  	ATA_IDX_OUTB(ch, ATA_BMSTAT_PORT, bmstat & ~ATA_BMSTAT_ERROR);
  	DELAY(1);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"