From owner-svn-src-all@FreeBSD.ORG Mon Oct 26 15:47:15 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1DAF106566B; Mon, 26 Oct 2009 15:47:15 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f209.google.com (mail-bw0-f209.google.com [209.85.218.209]) by mx1.freebsd.org (Postfix) with ESMTP id BA9D98FC24; Mon, 26 Oct 2009 15:47:14 +0000 (UTC) Received: by bwz1 with SMTP id 1so2507166bwz.13 for ; Mon, 26 Oct 2009 08:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=6+EmMMBbLLbMedj8wcrMg+b0MyDOTwmt8n/wB4zqwmU=; b=tbxYhxnDZXgE1o868BfHg3kvHzxctyihFxzzCZJ453AyvqQWDwGMG/S+Tct0rPs7cb FigcY+l+BWmmgI0Q6Ax+rXq+mHKzvE1Uk/HR9FfgBNeqJlQ2roVb9G9+Q9hU+f9e8peF qr2lFT0MAAfYPonEkQXlhfBc1oyzQja8ZzQlI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=AoLPPMfNCTTpV6922t6BSSBVdIHB7txMhkmdxfX73BuiHnJLE7bQ3ribhUsOF0yk9j tzv1tPyrzpewpLgQSok4qHPqKk7rhbLdM8SeohNTbhb+Yh+WF4vqAK5zax4LV+S+CZ1H ZOTyOEwofQzGyqJn+uQS2w51sRGxV0y8UouJM= Received: by 10.103.127.32 with SMTP id e32mr2543038mun.70.1256570270799; Mon, 26 Oct 2009 08:17:50 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id n10sm13854513mue.17.2009.10.26.08.17.48 (version=SSLv3 cipher=RC4-MD5); Mon, 26 Oct 2009 08:17:49 -0700 (PDT) Sender: Alexander Motin Message-ID: <4AE5CBA9.4080605@FreeBSD.org> Date: Mon, 26 Oct 2009 18:17:45 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20090901) MIME-Version: 1.0 To: Andriy Gapon References: <200910261120.n9QBKFUw086926@svn.freebsd.org> <20091026144252.GA11752@FreeBSD.org> <4AE5B788.5060407@freebsd.org> In-Reply-To: <4AE5B788.5060407@freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r198486 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 15:47:15 -0000 Andriy Gapon wrote: > on 26/10/2009 16:42 Alexey Dokuchaev said the following: >> On Mon, Oct 26, 2009 at 11:20:15AM +0000, Alexander Motin wrote: >>> Author: mav >>> Date: Mon Oct 26 11:20:14 2009 >>> New Revision: 198486 >>> URL: http://svn.freebsd.org/changeset/base/198486 >>> >>> Log: >>> Increase ATA command timeouts. Some drives need more then 5s to spin-up. >> Can't it be factored out into a macro so one does not have to make a bunch >> of those identical changes over several files shall it be required to >> adjust timeout again some time in the future? You are right, but I still hope to obsolete that code some time in the future. > If this is to happen, then I'd like them to become sysctls too. I think it is a bit excessive. System should work just out of the box without such tunings. Timeout is a fatal condition that should not happen within normal operation. The only reason to reduce it is faster fault recovery. But if faults happen often enough to require tuning, you should probably replace hardware. -- Alexander Motin