From owner-cvs-all@FreeBSD.ORG Thu Mar 16 03:49:37 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E246416A400; Thu, 16 Mar 2006 03:49:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F94243D53; Thu, 16 Mar 2006 03:49:33 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k2G3nVoH042214; Wed, 15 Mar 2006 22:49:32 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Wed, 15 Mar 2006 08:52:22 -0500 User-Agent: KMail/1.8.3 References: <200603140400.k2E40LiR095530@repoman.freebsd.org> <200603140825.40761.jhb@freebsd.org> <200603150730.36818.davidxu@freebsd.org> In-Reply-To: <200603150730.36818.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200603150852.23540.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1334/Wed Mar 15 13:13:15 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.5 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c kern_thread.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2006 03:49:38 -0000 On Tuesday 14 March 2006 06:30 pm, David Xu wrote: > On Tuesday 14 March 2006 21:25, John Baldwin wrote: > > On Monday 13 March 2006 11:00 pm, David Xu wrote: > > > davidxu 2006-03-14 04:00:21 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_exit.c kern_thread.c > > > Log: > > > 1. Count last time slice, this intends to fix > > > "calcru: runtime went backwards" bug for threaded process. > > > 2. Add comment about possible logical problem with scheduler. > > > > > > MFC after: 3 days > > > > Great! Thanks for testing this! > > I was very upset, and forgot to put your name in the log, apologize. > Note that because the thread has detached itself from scheduler, > calling PROC_UNLOCK in theory is not safe, so I have moved > up this patch code a bit. Ok. I think the PROC_UNLOCK might be ok in practice though because we are in a critical section, so we won't preempt when we unlock the mutex and will keep executing until we get to the cpu_throw. =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org