From owner-p4-projects@FreeBSD.ORG  Tue Sep  4 10:21:36 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4DBD716A41A; Tue,  4 Sep 2007 10:21:36 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2150316A418;
	Tue,  4 Sep 2007 10:21:36 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe12.swip.net [212.247.155.97])
	by mx1.freebsd.org (Postfix) with ESMTP id 89B5013C469;
	Tue,  4 Sep 2007 10:21:35 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [194.248.135.20] (account mc467741@c2i.net HELO laptop.lan)
	by mailfe12.swip.net (CommuniGate Pro SMTP 5.1.10)
	with ESMTPA id 429140094; Tue, 04 Sep 2007 11:21:32 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Xin LI <delphij@freebsd.org>
Date: Tue, 4 Sep 2007 11:21:45 +0200
User-Agent: KMail/1.9.7
References: <200709040755.l847tPbn003371@repoman.freebsd.org>
In-Reply-To: <200709040755.l847tPbn003371@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200709041121.45990.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 126033 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2007 10:21:36 -0000

Hi,

In my opinion you should keep braces around single line if's .

if (xxx) {
   yyy;
}

This will reduce the chance of error next time you add a statement to an if.

--HPS