From owner-svn-src-all@FreeBSD.ORG Thu Jun 4 05:21:26 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2ABDC08; Thu, 4 Jun 2015 05:21:25 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com [IPv6:2a00:1450:400c:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 760751D2B; Thu, 4 Jun 2015 05:21:25 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wiga1 with SMTP id a1so35363890wig.0; Wed, 03 Jun 2015 22:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=XbKSL4vs2yW8yS9GHRGqSB8EEDnwMNIa4ljh+6UEjK8=; b=QqPvCEuEYsrkvyC6fk9sKYIyYzfl35Vtr5fCwBJp7pcEFObeodYXxbhLVJyfsz9497 /5UPrf0wBlG8cAFfQxUrVeylfEzBjxl14pYAqeqEvw8ODUloWlplIg3ZDAPFjANNeVVv 9Mq+WJ/2lsGK4DAzCGzvpZAUmAXULZlGCecFwIgmH9MCRh1RBxoGkqv3bGDqgzoY4dTS G5Oc8uzoA6xZhIPPLFMEAWptDxBTVTrkU959imszO+yN8szzOGRj1Q5LWFpHJ33PtM1B iXSzIYwCGPip9kwP7jDhqgdCblcGkn0WYw8xDQEkKJpMGEw7Vn8ILJGHA2b7PqTrx9oC gDCQ== X-Received: by 10.194.178.39 with SMTP id cv7mr34728301wjc.100.1433395283963; Wed, 03 Jun 2015 22:21:23 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id c3sm3958167wja.3.2015.06.03.22.21.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 22:21:23 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 4 Jun 2015 07:21:21 +0200 From: Baptiste Daroussin To: d@delphij.net Cc: Sergey Kandaurov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, nectar@FreeBSD.org Subject: Re: svn commit: r283969 - head/lib/libutil Message-ID: <20150604052120.GH32562@ivaldir.etoilebsd.net> References: <201506032048.t53KmSCf074619@svn.freebsd.org> <20150603215841.GF32562@ivaldir.etoilebsd.net> <556F8322.9050602@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CD/aTaZybdUisKIc" Content-Disposition: inline In-Reply-To: <556F8322.9050602@delphij.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 05:21:26 -0000 --CD/aTaZybdUisKIc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 03, 2015 at 03:43:46PM -0700, Xin Li wrote: > On 06/03/15 14:58, Baptiste Daroussin wrote: > > On Thu, Jun 04, 2015 at 12:51:46AM +0300, Sergey Kandaurov wrote: > >> On 3 June 2015 at 23:48, Baptiste Daroussin > >> wrote: > >>> Author: bapt Date: Wed Jun 3 20:48:28 2015 New Revision: > >>> 283969 URL: https://svnweb.freebsd.org/changeset/base/283969 > >>>=20 > >>> Log: Add a pw_mkdb2(3) function which does the same thing as > >>> pw_mkdb(3) except it takes a new argument allowing to specify > >>> the endianness of the database to generate > >>>=20 > >>=20 > >> Why not change pw_mkdb()? Is it used outside of the project? > >>=20 > > Because that would change the ABI of libutil and it is not a > > private library aka we are supposed to maintain ABI compatibility > > as we do not know if it is used or not externally to the project. I > > care about the ABI because I have made this change in order to use > > it in pw(8) and MFC it to stable/10 before 10.2. > >=20 > > libutil is not versionned so this is the only way to not break the > > ABI. Except if someone has a better idea than I do. >=20 > Looking at r113596, pwd_mkdb(8) was changed to generate both legacy > (version 3, endianness sensitive) and new (version 4, machine > independent) formats. >=20 > Now, after 12 years, is it still sensible to generate legacy format db > entries? Maybe we should just disable the generation by default and > eventually remove the ability to generate them? >=20 That could be an option, in this case we could add a -l (legacy) option to pwd_mkdb to allow the users to generate the db in legacy format and drop su= pport support for legacy format in all other tools. Meaning I can revert pw_mkdb2= (3) If noone raised a voice against disable the generation by default, I'll do = it in a couple of days. Best regards, Bapt --CD/aTaZybdUisKIc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVv4E8ACgkQ8kTtMUmk6EzcJQCgj7JXlzynJdha7X8XIVawQ0Il 8W8AnR27CtARQzhy5+YG4qM2QnlXkrEF =cIO6 -----END PGP SIGNATURE----- --CD/aTaZybdUisKIc--