From owner-cvs-src@FreeBSD.ORG Wed May 10 07:15:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 648C516A402; Wed, 10 May 2006 07:15:38 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34E7D43D49; Wed, 10 May 2006 07:15:38 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k4A7FcKw056351; Wed, 10 May 2006 07:15:38 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k4A7Fc0d056350; Wed, 10 May 2006 07:15:38 GMT (envelope-from pjd) Message-Id: <200605100715.k4A7Fc0d056350@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 10 May 2006 07:15:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/geom/raid3 g_raid3.c g_raid3.h g_raid3_ctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2006 07:15:38 -0000 pjd 2006-05-10 07:15:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/geom/raid3 g_raid3.c g_raid3.h g_raid3_ctl.c Log: MFC: sys/geom/raid3/g_raid3.c 1.60,1.62,1.63,1.66 sys/geom/raid3/g_raid3.h 1.18 sys/geom/raid3/g_raid3_ctl.c 1.16 Sync graid3 with HEAD. - Introduce and use delayed-destruction functionality from a pre-sync hook, which means that devices will be destroyed on last close. This fixes destruction order problems when, eg. RAID3 array is build on top of RAID1 arrays. Requested, reviewed and tested by: ru - Be sure to not destroy device twice. This is only possible in theory, but with this change there is even no theoretical race. - Remove dead code. - Comment possible event miss, which isn't critical, but probably can be fixed by replacing the event lock usage with the queue lock. - Use G_RAID3_FOREACH_SAFE_BIO() macro instead of G_RAID3_FOREACH_BIO() in two places where g_io_request() is called. g_io_request() can free bio structure so we can't reference it after and G_RAID3_FOREACH_BIO() macro was doing this. Found by: Coverity Prevent analysis tool (with my new models) Revision Changes Path 1.40.2.11 +94 -74 src/sys/geom/raid3/g_raid3.c 1.11.2.3 +5 -1 src/sys/geom/raid3/g_raid3.h 1.11.2.2 +7 -1 src/sys/geom/raid3/g_raid3_ctl.c