From owner-freebsd-current  Sat Oct 19 15:11:38 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6579637B401; Sat, 19 Oct 2002 15:11:36 -0700 (PDT)
Received: from obsecurity.dyndns.org (adsl-64-165-226-88.dsl.lsan03.pacbell.net [64.165.226.88])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9605E43E6A; Sat, 19 Oct 2002 15:11:35 -0700 (PDT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 049A766E66; Sat, 19 Oct 2002 15:11:34 -0700 (PDT)
Date: Sat, 19 Oct 2002 15:11:34 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: Clement Laforet <sheepkiller@cultdeadsheep.org>
Cc: Kris Kennaway <kris@obsecurity.org>, sobomax@FreeBSD.ORG,
	current@FreeBSD.ORG, ports@FreeBSD.ORG
Subject: Re: New 5.0 ports uploaded
Message-ID: <20021019221133.GA9562@xor.obsecurity.org>
References: <20021019012219.GA86396@xor.obsecurity.org> <20021019051918.GC14922@vega.vega.com> <20021019205848.GB7186@xor.obsecurity.org> <20021019235737.2e1987e9.sheepkiller@cultdeadsheep.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ"
Content-Disposition: inline
In-Reply-To: <20021019235737.2e1987e9.sheepkiller@cultdeadsheep.org>
User-Agent: Mutt/1.4i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


--mP3DRpeJDSE+ciuQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 19, 2002 at 11:57:37PM +0200, Clement Laforet wrote:
> On Sat, 19 Oct 2002 13:58:48 -0700
> Kris Kennaway <kris@obsecurity.org> wrote:
>=20
> > Sorry, my statement wasn't clear.  I'll be doing something of the form
> >=20
> > .if ${OSVERSION} > 500000
> > BROKEN=3D	"Does not compile on FreeBSD 5.x"
> > .endif
> >=20
> > This will not affect users of 4.x
> >
>=20
> Is there a "correct" way to name patches dedicated to 5.x ?

The patches should be applied in all cases (i.e. 4.x as well); if the
patch contains code that should not be compiled in the 4.x case then
compile it conditionally using something like:

#if defined(__FreeBSD__) && (__FreeBSD_version >=3D 5000xx)
=2E..
#endif

See the porter's handbook for more information about this.

Kris

--mP3DRpeJDSE+ciuQ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9sdiVWry0BWjoQKURAoblAJwLLTQm09BLl97OEWRm3D3D98oLzQCfdL/n
OsdEXafoY8ydPDnOyDcI89g=
=/WQz
-----END PGP SIGNATURE-----

--mP3DRpeJDSE+ciuQ--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message