From owner-svn-ports-head@FreeBSD.ORG Mon Jan 27 14:12:33 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 05EF5DAB; Mon, 27 Jan 2014 14:12:33 +0000 (UTC) Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 20A1C1D0D; Mon, 27 Jan 2014 14:12:31 +0000 (UTC) Received: by mail-we0-f181.google.com with SMTP id u56so5215680wes.40 for ; Mon, 27 Jan 2014 06:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=PUXvObizLc9KBvxKjxohssk6vWaT9P+1j7dIUK1tNFw=; b=BaQQkvNcWldwcQLa4abZB9VsW+SxDydtPXvm2ns+ukFqWueBqcqHCedQ6PAjKiPvzd 5c9bnhgvQo6UZXzgJgX1O5IgwtswRM06zbV6cr8AGuyS7yQn5MtzJMQN5o9S4CNw4PFn ROy/TUnK3+8E6NzEiL9bjRLyDXdXK/Ix9Y4esHWr/v8IOK1tmVGoQdaZlXaAUa6wOL6Z 1P0us3grF2sDYJNlBsPNoxdVjVmcuh+dwjE6QfNpWTmRhYt8YcaVdsmt1IZHEVGrw2eO StM/9lmK5QjKQEBQYHfn5dbxRTUgRmp4+H04/3+XhmmMfsBzOs2okq9wXdpxhQsyAfK7 gq4w== X-Received: by 10.194.202.230 with SMTP id kl6mr20926381wjc.9.1390831950433; Mon, 27 Jan 2014 06:12:30 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fz5sm28052168wic.11.2014.01.27.06.12.27 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 27 Jan 2014 06:12:28 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 27 Jan 2014 15:12:26 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r341406 - head/devel/bncsutil-ghost++ Message-ID: <20140127141225.GA33006@ithaqua.etoilebsd.net> References: <201401271337.s0RDbvuO022647@svn.freebsd.org> <20140127140836.GB68244@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <20140127140836.GB68244@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 14:12:33 -0000 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2014 at 02:08:36PM +0000, Alexey Dokuchaev wrote: > On Mon, Jan 27, 2014 at 01:37:57PM +0000, Baptiste Daroussin wrote: > > New Revision: 341406 > > URL: http://svnweb.freebsd.org/changeset/ports/341406 > > QAT: https://qat.redports.org/buildarchive/r341406/ > >=20 > > +MAKE_ARGS=3D PREFIX=3D${STAGEDIR}${PREFIX} >=20 > It would be nice (per our previous discussion) to briefly summarize in the > commit log why, in the particular case, such construct is safe, as genera= lly > is is not. >=20 > ./danfe Right in that case I check that PREFIX is only used during the install phas= e (in the upstream build process) I also checked that the install process wasn't = going to hardcode PREFIX somewhere. I run stage-qa and verified if nothing yelled at me :) With both checks I knew that it was safe to cheat on the prefix to install directly on stagedir. regards, Bapt --envbJBWh7q8WU6mo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLmaUkACgkQ8kTtMUmk6EyYuACeI8psfpVY/dsU60ViY8pUc8yF lSUAniYYv8Xh7zGNgVT1LL0M1+9kto/u =I3AY -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--