From owner-cvs-ports@FreeBSD.ORG Mon Apr 30 09:24:28 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 045A71065670; Mon, 30 Apr 2012 09:24:28 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward11.mail.yandex.net (forward11.mail.yandex.net [IPv6:2a02:6b8:0:801::1]) by mx1.freebsd.org (Postfix) with ESMTP id 68C9C8FC15; Mon, 30 Apr 2012 09:24:27 +0000 (UTC) Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward11.mail.yandex.net (Yandex) with ESMTP id E2326E812A3; Mon, 30 Apr 2012 13:24:25 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1335777866; bh=fE1ZlByJ4xv5+YmlsACtnctsoyLG7yKZG8NhAZOUXP8=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=PhK5wq6UDbY3noJSH+4wZ5J0e8H0wFneG8RUy897WCUc7QKdrkFUuyXctc8kX+p3n r6grg1KYZ/KQRJnOdjNuHfvbZssD3SceA17lbalhOjiI7+B1MQU134vNzYNinBDg2a +nf/vLPEyo7UQUW7rcrU0jEruzdW4n9JG9MHxbFI= Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id A4FC37E0503; Mon, 30 Apr 2012 13:24:25 +0400 (MSK) Received: from unknown (unknown [178.76.224.133]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id OPKWXR6Q-OPK0mYU2; Mon, 30 Apr 2012 13:24:25 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1335777865; bh=fE1ZlByJ4xv5+YmlsACtnctsoyLG7yKZG8NhAZOUXP8=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=jkk4gE1zWqdRbjtJshMd7nA2bhU0XLE1uPNf7LfuE0OovHT9A1Fj1JOd18s5uxswG MumvLq3YixuYgKkXuPmjV+SK7S7l6L5q6bpPHuLudcqtpi+Q8OjaaM37pkYis+ehLI fzJnAYjLtW0b0WbRNUAl5nAGmiqyZDvA1XLotRgE= Message-ID: <4F9E5A0C.6000607@yandex.ru> Date: Mon, 30 Apr 2012 13:23:24 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120426 Thunderbird/12.0 MIME-Version: 1.0 To: Nicola Vitale References: <201204300856.q3U8uWfU059239@repoman.freebsd.org> In-Reply-To: <201204300856.q3U8uWfU059239@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/py-google-api-python-client Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2012 09:24:28 -0000 Hi Nicola, Nicola Vitale wrote on 30.04.2012 12:56: > nivit 2012-04-30 08:56:32 UTC > > FreeBSD ports repository > > Modified files: > www/py-google-api-python-client Makefile distinfo pkg-descr > pkg-plist > Log: > - Update to 1.0.b8 > - Add devel/py-simplejson to *_DEPENDS > - Add www/py-WebTest to RUN_DEPENDS > - Add LICENSE (AL2) > - Add some API names to pkg-descr > - Remove DISTNAME from Makefile > > Revision Changes Path > 1.3 +8 -5 ports/www/py-google-api-python-client/Makefile > 1.3 +2 -2 ports/www/py-google-api-python-client/distinfo > 1.2 +5 -2 ports/www/py-google-api-python-client/pkg-descr > 1.3 +211 -364 ports/www/py-google-api-python-client/pkg-plist It only using simplejson as a fallback for python <2.6. See setup.py: """ try: import json needs_json = False except ImportError: needs_json = True if needs_json: install_requires.append('simplejson') """ and in google-api-python-client-1.0beta8/oauth2client/anyjson.py: """ try: # pragma: no cover # Should work for Python2.6 and higher. import json as simplejson except ImportError: # pragma: no cover try: import simplejson """ So simplejson dependency isn't needed here (python 2.4/2.5 are EOL and subject of removal). And BUILD_DEPENDS seems redundant, because this deps is only defined in install_requires (read, RUN_DEPENDS), not in setup_requires (BUILD_DEPENDS equivalent). So I'd drop it too, but needs tinderbox check. -- Regards, Ruslan Tinderboxing kills... the drives.