From owner-cvs-all Mon Apr 23 2:30:31 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 41CDF37B43E; Mon, 23 Apr 2001 02:30:25 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 744166ACBA; Mon, 23 Apr 2001 19:00:23 +0930 (CST) Date: Mon, 23 Apr 2001 19:00:23 +0930 From: Greg Lehey To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_bmap.c cd9660_lookup.c cd9660_node.c cd9660_rrip.c cd9660_util.c cd9660_vfsops.c cd9660_vnops.c Message-ID: <20010423190023.D37321@wantadilla.lemis.com> References: <20010423183839.C37321@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from bde@zeta.org.au on Mon, Apr 23, 2001 at 07:25:09PM +1000 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Monday, 23 April 2001 at 19:25:09 +1000, Bruce Evans wrote: > On Mon, 23 Apr 2001, Greg Lehey wrote: > >> On Monday, 23 April 2001 at 18:57:53 +1000, Bruce Evans wrote: >>> Arggh. This is the start of breaking the includes in approx. 133 files to >>> work with recent breakage in . Approx. 133 files that have >>> nothing to do with either networking or radixes now need to include >>> . >> >> Well, it doesn't exactly seem to be correct to redefine AF_MAX in >> sys/mount.h to get around it. But pass me the pointy hat: I checked >> with make world and forgot LINT. > > Defining AF_MAX in 2 places is easier than having a whole header just for > defining AF_MAX. The definitions won't get out of sync, because building > kernels will give warnings about them being different, and committed code > doesn't cause warnings ;-). > > The include of is unrelated to this. is already > close to being a secondary header that is included in primary headers like > and . It is only included directly in a few > networking .c files, and half of those includes are bogus anyway, since > the files also include . ( doesn't include > if RNF_NORMAL is defined, but I don't see how defining > RNF_NORMAL could actually work in the kernel. It is apparently intended > for permitting an alternative to , but since other parts of > the kernel just include , there would probably be at best > namespace conflicts with any alternative.) Good analysis. You didn't answer the second part of my message: > So what would you suggest? At the moment, GENERIC builds. LINT doesn't. I have the fixes to LINT ready to commit, but there's not much point if you think I should back all the crap out. > BTW, 133 is from "grep -c sys/mount.h LINT/.depend". Yes, I thought as much. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message