From owner-freebsd-embedded@FreeBSD.ORG  Fri Dec 23 12:05:11 2011
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4F691106566C;
	Fri, 23 Dec 2011 12:05:11 +0000 (UTC) (envelope-from stb@lassitu.de)
Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea])
	by mx1.freebsd.org (Postfix) with ESMTP id 149348FC17;
	Fri, 23 Dec 2011 12:05:11 +0000 (UTC)
Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 52C0F83908;
	Fri, 23 Dec 2011 13:05:10 +0100 (CET)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=us-ascii
From: Stefan Bethke <stb@lassitu.de>
In-Reply-To: <20111223122947.4235c390.ray@freebsd.org>
Date: Fri, 23 Dec 2011 13:05:09 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0@lassitu.de>
References: <20111223122947.4235c390.ray@freebsd.org>
To: Aleksandr Rybalko <ray@freebsd.org>
X-Mailer: Apple Mail (2.1251.1)
Cc: embedded@freebsd.org
Subject: Re: geom_uncompress
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2011 12:05:11 -0000

Very cool!

Am 23.12.2011 um 11:29 schrieb Aleksandr Rybalko:

> http://my.ddteam.net/files/geom_uncompress_2011-12-23_2.patch

In your original patch in February 2010, you supported only lzma.  In =
this version, your module supports both zlib and lzma compression.  =
Wouldn't it make more sense to replace geom_uzip, and integrate mkuzip =
and mklzma into a single utility?

I also faintly remember some bike shed about the original geom_uzip =
name.

The magic header definition should likely be in a common file, shared =
between the utility(s) and the geom module(s).

And a final nitpick: we really don't have a suitable crc32 function in =
the kernel already?


Stefan

--=20
Stefan Bethke <stb@lassitu.de>   Fon +49 151 14070811