From owner-svn-ports-head@FreeBSD.ORG Mon Jan 27 14:24:58 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4A4D04DB; Mon, 27 Jan 2014 14:24:58 +0000 (UTC) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 61E241E3B; Mon, 27 Jan 2014 14:24:57 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id l18so5526315wgh.23 for ; Mon, 27 Jan 2014 06:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=QrA+ycpiCM2QTp7YiRhMg6ALPe5yljMKLHdUS3beTKc=; b=bEsfVMRRB9i9jnrMzHqLSDnlwa86yQ6wwCNlsAzuXPVAulBluwhhE74y4u4q3INJ5Q LHor0J/+wt56G5x3eY939/LfHVV/OseWGTdTGsE36DPKicHqODGxx3l29se4GFNL7b4N vgnriBEo3UH/l3gXyfYqEK3kJWAhRaOMl5yghUy5ALduoDymXSaPwi3FtSY3mNjV1XNZ WOcMObfJWutxWe5NXcGw+20s3AKgu8ShpnHrs5Y7+yxER4PfPywS5bVlA3pNLL+6GA6Y kI4Uj9kHtHyIFsSArdfeY5BvFtuwf3AaNNJIA7/lPTo1u8GktcmY63STPBC86YRKZf6N PN7A== X-Received: by 10.180.21.166 with SMTP id w6mr12124800wie.31.1390832695747; Mon, 27 Jan 2014 06:24:55 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fb8sm5043984wic.3.2014.01.27.06.24.53 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 27 Jan 2014 06:24:54 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 27 Jan 2014 15:24:52 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r341406 - head/devel/bncsutil-ghost++ Message-ID: <20140127142451.GB33006@ithaqua.etoilebsd.net> References: <201401271337.s0RDbvuO022647@svn.freebsd.org> <20140127140836.GB68244@FreeBSD.org> <20140127141225.GA33006@ithaqua.etoilebsd.net> <20140127142052.GA71123@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UHN/qo2QbUvPLonB" Content-Disposition: inline In-Reply-To: <20140127142052.GA71123@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 14:24:58 -0000 --UHN/qo2QbUvPLonB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2014 at 02:20:52PM +0000, Alexey Dokuchaev wrote: > On Mon, Jan 27, 2014 at 03:12:26PM +0100, Baptiste Daroussin wrote: > > On Mon, Jan 27, 2014 at 02:08:36PM +0000, Alexey Dokuchaev wrote: > > > On Mon, Jan 27, 2014 at 01:37:57PM +0000, Baptiste Daroussin wrote: > > > > New Revision: 341406 > > > > URL: http://svnweb.freebsd.org/changeset/ports/341406 > > > > QAT: https://qat.redports.org/buildarchive/r341406/ > > > >=20 > > > > +MAKE_ARGS=3D PREFIX=3D${STAGEDIR}${PREFIX} > > >=20 > > > It would be nice (per our previous discussion) to briefly summarize in > > > the commit log why, in the particular case, such construct is safe, as > > > generally is is not. > >=20 > > Right; in that case I check that PREFIX is only used during the install > > phase (in the upstream build process) I also checked that the install > > process wasn't going to hardcode PREFIX somewhere. [...] >=20 > Baptiste, I know that you, as overall accurate committer, had done all > the checking required to ensure that this construct, in this particular > case is OK. My point is that it better be briefly reflected in the log, > as other, less careful or experienced folks might see it as "Oh, OK, I > can simply set prefix to ${STAGEDIR}/${PREFIX} and be cone with it." >=20 Right, I'll do next time:) regards, Bapt --UHN/qo2QbUvPLonB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLmbDMACgkQ8kTtMUmk6Ext/wCfVLbQFH9vbVEPGIbDbqLYUjKP KYUAn2nF71XIbDasJk4ayfWcJmk6ijjY =p4o0 -----END PGP SIGNATURE----- --UHN/qo2QbUvPLonB--