From owner-svn-src-all@FreeBSD.ORG Sun Apr 26 20:54:57 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E74C106564A; Sun, 26 Apr 2009 20:54:57 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7E25A8FC08; Sun, 26 Apr 2009 20:54:57 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3QKsvps094234; Sun, 26 Apr 2009 20:54:57 GMT (envelope-from alc@svn.freebsd.org) Received: (from alc@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3QKsv2N094233; Sun, 26 Apr 2009 20:54:57 GMT (envelope-from alc@svn.freebsd.org) Message-Id: <200904262054.n3QKsv2N094233@svn.freebsd.org> From: Alan Cox Date: Sun, 26 Apr 2009 20:54:57 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r191531 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Apr 2009 20:54:58 -0000 Author: alc Date: Sun Apr 26 20:54:57 2009 New Revision: 191531 URL: http://svn.freebsd.org/changeset/base/191531 Log: Eliminate an archaic band-aid. The immediately preceding comment already explains why the band-aid is unnecessary. Suggested by: tegge Modified: head/sys/vm/vm_fault.c Modified: head/sys/vm/vm_fault.c ============================================================================== --- head/sys/vm/vm_fault.c Sun Apr 26 19:16:32 2009 (r191530) +++ head/sys/vm/vm_fault.c Sun Apr 26 20:54:57 2009 (r191531) @@ -916,13 +916,11 @@ vnode_locked: KASSERT(fs.m->oflags & VPO_BUSY, ("vm_fault: page %p not busy!", fs.m)); /* - * Sanity check: page must be completely valid or it is not fit to + * Page must be completely valid or it is not fit to * map into user space. vm_pager_get_pages() ensures this. */ - if (fs.m->valid != VM_PAGE_BITS_ALL) { - vm_page_zero_invalid(fs.m, TRUE); - printf("Warning: page %p partially invalid on fault\n", fs.m); - } + KASSERT(fs.m->valid == VM_PAGE_BITS_ALL, + ("vm_fault: page %p partially invalid", fs.m)); VM_OBJECT_UNLOCK(fs.object); /*