From owner-cvs-all  Sat Feb 10 12:18: 1 2001
Delivered-To: cvs-all@freebsd.org
Received: from columbus.cris.net (columbus.cris.net [212.110.128.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id D6CA937B491; Sat, 10 Feb 2001 12:17:31 -0800 (PST)
Received: from ark.cris.net (ns2.cris.net [212.110.128.68])
	by columbus.cris.net (8.9.3/8.9.3) with ESMTP id WAA04595;
	Sat, 10 Feb 2001 22:16:06 +0200 (EET)
Received: (from phantom@localhost)
	by ark.cris.net (8.11.1/8.11.1) id f1AKGw460257;
	Sat, 10 Feb 2001 22:16:58 +0200 (EET)
Date: Sat, 10 Feb 2001 22:16:58 +0200
From: Alexey Zelkin <phantom@FreeBSD.org>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/locale fix_grouping.c Makefile.inc lmonetary.c lnumeric.c localeconv.c
Message-ID: <20010210221658.A55284@ark.cris.net>
References: <200102101536.f1AFalt39792@freefall.freebsd.org> <20010210203601.A75114@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0i
In-Reply-To: <20010210203601.A75114@nagual.pp.ru>; from ache@nagual.pp.ru on Sat, Feb 10, 2001 at 08:36:01PM +0300
X-Operating-System: FreeBSD 3.5-STABLE i386
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

hi,

On Sat, Feb 10, 2001 at 08:36:01PM +0300, Andrey A. Chernov wrote:

> > phantom     2001/02/10 07:36:47 PST
> > 
> >   Modified files:
> >     lib/libc/locale      Makefile.inc lmonetary.c lnumeric.c 
> >                          localeconv.c 
> >   Added files:
> >     lib/libc/locale      fix_grouping.c 
> >   Log:
> >   . Fix semantics of grouping (LC_MONETARY::mon_grouping,
> >     LC_NUMERIC::grouping) values.
> >   . Always set __XXX_changed flags then loading numeric & monetary locale
> >     categories to allow localeconv() to use C locale also.
> 
> lmonetary.c lnumeric.c:
> C locale - numempty[] is wrong. It is double-converted as result. It must
> be "-1".
How ? Conversion is related to loaded locale part only. It does not
affect predefined _C_ locale structures.

> Current path numempty -> cnv -> localeconv is
> "\x7F" -> 0 in your variant
> "-1" -> 0x7F in right variant

> fix_grouping.c:
> missing <ctype.h> for isdigit()
> isdigit() arg must be casted to (unsigned char)
Done. Thanks for reminder!

-- 
/* Alexey Zelkin               && phantom@cris.net       */
/* Tavric National University  && phantom@FreeBSD.org    */
/* Sysadmin/Developer          && phantom@sms.umc.com.ua */


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message