From owner-freebsd-bugs@FreeBSD.ORG Sun Mar 21 01:50:02 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 225441065676 for ; Sun, 21 Mar 2010 01:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D9FA08FC18 for ; Sun, 21 Mar 2010 01:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2L1o1dG019925 for ; Sun, 21 Mar 2010 01:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2L1o1eJ019924; Sun, 21 Mar 2010 01:50:01 GMT (envelope-from gnats) Resent-Date: Sun, 21 Mar 2010 01:50:01 GMT Resent-Message-Id: <201003210150.o2L1o1eJ019924@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 611E31065680 for ; Sun, 21 Mar 2010 01:49:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 509A08FC1E for ; Sun, 21 Mar 2010 01:49:30 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2L1nUji078245 for ; Sun, 21 Mar 2010 01:49:30 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o2L1nUG4078244; Sun, 21 Mar 2010 01:49:30 GMT (envelope-from nobody) Message-Id: <201003210149.o2L1nUG4078244@www.freebsd.org> Date: Sun, 21 Mar 2010 01:49:30 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/144920: [patch] [pkg_install] Remove useless chmod after mkdtemp(3) call X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2010 01:50:02 -0000 >Number: 144920 >Category: bin >Synopsis: [patch] [pkg_install] Remove useless chmod after mkdtemp(3) call >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Mar 21 01:50:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9-CURRENT >Organization: Cisco Systems, Inc. >Environment: >Description: There's a useless chmod(2) to 0700 after a mkdtemp(3) call in make_playpen in lib/pen.c. According to mkdtemp(3), this is automatically being done by default: The mkdtemp() function makes the same replacement to the template as in mktemp() and creates the template directory, mode 0700. >How-To-Repeat: >Fix: See patch. Patch attached with submission follows: ==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/usr.sbin/pkg_install/lib/pen.c#1 - /scratch/freebsd/perforce/pkg_install-enhancements/usr.sbin/pkg_install/lib/pen.c ==== @@ -113,10 +113,6 @@ cleanup(0); errx(2, "%s: can't mktemp '%s'", __func__, pen); } - if (chmod(pen, 0700) == FAIL) { - cleanup(0); - errx(2, "%s: can't mkdir '%s'", __func__, pen); - } if (Verbose) { if (sz) { >Release-Note: >Audit-Trail: >Unformatted: