From owner-svn-ports-all@FreeBSD.ORG  Thu Nov 29 07:44:07 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id D0769544; Thu, 29 Nov 2012 07:44:07 +0000 (UTC)
Date: Thu, 29 Nov 2012 07:44:07 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r307952 - head/sysutils/autopsy
Message-ID: <20121129074407.GA30088@FreeBSD.org>
References: <201211290106.qAT167gl065017@svn.freebsd.org>
 <20121129065722.GA27403@FreeBSD.org> <50B70CE4.9050508@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <50B70CE4.9050508@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 Emanuel Haupt <ehaupt@FreeBSD.org>, ports-committers@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2012 07:44:07 -0000

On Thu, Nov 29, 2012 at 01:21:08AM -0600, Bryan Drewery wrote:
> I may have been wrong to suggest this since it was not a LIB_DEPENDS.

True.

> However, are you suggesting that for shlib chases one should install and
> inspect every port to see if they actually link to the library, or even
> look for it?

Yes, of course, obviously.  This is our jobs as maintainers (or committers,
FWIW).  Maybe not install, but at least extract, see how it builds, inspect
pkg-plist, etc.  That's what I normally do.

> That must be quite a task for things like png.

png is usually recorded as LIB_DEPENDS, it's different.

> I would rather be safe than to assume that all LIB_DEPENDS are recorded
> correctly vs not just being RUN_DEPENDS and to cause problems for users.

I beg to disagree; in fact, it's a good time to recheck all dependent port
that are !LIB_DEPENDS to see if dependencies are correct.  In this case, it
was particularly easy as it is rather small and clearly perlish.  Not to
mention that you can always ask previous maintainer (me in this case).

./danfe