From owner-cvs-src@FreeBSD.ORG Fri Aug 20 20:42:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27BC916A4CF; Fri, 20 Aug 2004 20:42:41 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38D7B43D31; Fri, 20 Aug 2004 20:42:40 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i7KKgZsW059444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Aug 2004 23:42:36 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i7KKgato073585; Fri, 20 Aug 2004 23:42:36 +0300 (EEST) (envelope-from ru) Date: Fri, 20 Aug 2004 23:42:36 +0300 From: Ruslan Ermilov To: Andre Oppermann Message-ID: <20040820204236.GA73564@ip.net.ua> References: <20040820192058.3BE26790032@ws1-14.us4.outblaze.com> <41265A04.25A48B17@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <41265A04.25A48B17@freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new cc: cvs-src@freebsd.org cc: "P.D. Seniura" Subject: Re: problem in building modules-with-world re: cvs commit:src/sys/netinet ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2004 20:42:41 -0000 --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 20, 2004 at 10:07:32PM +0200, Andre Oppermann wrote: > > > > [...] > > > > =3D=3D=3D> ipfw > > > > rm -f .depend > > > > mkdep -f .depend -a -nostdinc -DIPFIREWALL -D_KERNEL -DKLD_MODULE= -I- -I. -I@ -I@/contrib/altq -I@/../include /src/sys/modules/ipfw/../../ne= tinet/ip_fw2.c /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c > > > > /src/sys/modules/ipfw/../../netinet/ip_fw2.c:35:22: opt_ipfw.h: No = such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw2.c:36:22: opt_ipdn.h: No = such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw2.c:37:26: opt_ipdivert.h:= No such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw2.c:38:22: opt_inet.h: No = such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw2.c:39:23: opt_ipsec.h: No= such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw2.c:41:2: #error IPFIREWAL= L requires INET. > > > > /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c:29:22: opt_ipfw.h:= No such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c:30:22: opt_ipdn.h:= No such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c:31:26: opt_ipdiver= t.h: No such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c:32:28: opt_pfil_ho= oks.h: No such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c:33:22: opt_inet.h:= No such file or directory > > > > /src/sys/modules/ipfw/../../netinet/ip_fw_pfil.c:35:2: #error IPFIR= EWALL requires INET. > > > > mkdep: compile failed > > > > *** Error code 1 (continuing) > > > > `depend' not remade because of errors. > > > > =3D=3D=3D> ip_mroute_mod > > > > [...] > > > > > > I have just cvsupped -current and the GENERIC kernel compiles just fi= ne. > > > > > > Looking at the error message in your log output one might conclude th= at you > > > are missing "option INET" in your kernel config? > >=20 > > MODULES_WITH_WORLD > >=20 > > Please read the subject line. ;) >=20 > Ok, there seems to be a problem with setting up the environment when doing > this. Why do you build modules with WORLD instead of doing it with the > kernel? This sounds quite dangerous to me when kernel/modules go out of > sync. >=20 > Ruslan, do you have any idea what is going wrong? >=20 Yes. You removed far too much in your conversion. ;) %%% Index: ip_fw2.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/netinet/ip_fw2.c,v retrieving revision 1.73 diff -u -p -r1.73 ip_fw2.c --- ip_fw2.c 19 Aug 2004 23:31:40 -0000 1.73 +++ ip_fw2.c 20 Aug 2004 20:37:14 -0000 @@ -32,6 +32,7 @@ * Implement IP packet firewall (new version) */ =20 +#if !defined(KLD_MODULE) #include "opt_ipfw.h" #include "opt_ipdn.h" #include "opt_ipdivert.h" @@ -40,6 +41,7 @@ #ifndef INET #error IPFIREWALL requires INET. #endif /* INET */ +#endif =20 #define IPFW2 1 #if IPFW2 Index: ip_fw_pfil.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/netinet/ip_fw_pfil.c,v retrieving revision 1.5 diff -u -p -r1.5 ip_fw_pfil.c --- ip_fw_pfil.c 20 Aug 2004 00:36:55 -0000 1.5 +++ ip_fw_pfil.c 20 Aug 2004 20:39:50 -0000 @@ -26,6 +26,7 @@ * $FreeBSD: src/sys/netinet/ip_fw_pfil.c,v 1.5 2004/08/20 00:36:55 andre = Exp $ */ =20 +#if !defined(KLD_MODULE) #include "opt_ipfw.h" #include "opt_ipdn.h" #include "opt_ipdivert.h" @@ -34,9 +35,10 @@ #ifndef INET #error IPFIREWALL requires INET. #endif /* INET */ -#if !defined(KLD_MODULE) && !defined(PFIL_HOOKS) +#if !defined(PFIL_HOOKS) #error IPFIREWALL requires PFIL_HOOKS. #endif +#endif =20 #include #include %%% Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (FreeBSD) iD8DBQFBJmI8qRfpzJluFF4RAhF0AJ9QITj//tGsyNz/3s9WRh97Dggj1wCfa1cA cE4jb0ZmEd1j1cgUaEhjm34= =e+Po -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--