From owner-freebsd-ports@FreeBSD.ORG Mon Jul 7 16:35:02 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FD94106566C; Mon, 7 Jul 2008 16:35:02 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73]) by mx1.freebsd.org (Postfix) with ESMTP id E024D8FC2D; Mon, 7 Jul 2008 16:35:01 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from [213.142.183.219] (helo=gahrtop.localhost) by cpanel03.rubas-s03.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1KFtg4-0000m9-J9; Mon, 07 Jul 2008 18:35:00 +0200 Message-ID: <487245AE.1030307@FreeBSD.org> Date: Mon, 07 Jul 2008 18:34:54 +0200 From: Pietro Cerutti Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.14 (X11/20080610) MIME-Version: 1.0 To: fjoe@FreeBSD.org, bug-followup , ports@freebsd.org References: <200807071619.m67GJrPt096421@freefall.freebsd.org> In-Reply-To: <200807071619.m67GJrPt096421@freefall.freebsd.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=9571F78E; url=http://gahr.ch/pgp/ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel03.rubas-s03.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - FreeBSD.org X-Source: X-Source-Args: X-Source-Dir: Cc: Subject: Re: ports/124985: [patch] devel/dmucs unbreak on 64bits archs X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2008 16:35:02 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 fjoe@FreeBSD.org wrote: | Synopsis: [patch] devel/dmucs unbreak on 64bits archs | | State-Changed-From-To: open->closed | State-Changed-By: fjoe | State-Changed-When: Mon Jul 7 16:18:07 UTC 2008 | State-Changed-Why: | Proper integer type for holding pointers is "long", not "size_t". I definitely do not agree. Please note that a pointer is not required to fit into a long, while it is required to fit into a size_t. Your solution may work as soon as we are concerned only with LP64 machines. As soon as a LLP64 arch steps in, you break things. | Also, std:map<> containers where sockets are stored should be modified. | | Corrected version of the patch committed, thanks! | | http://www.freebsd.org/cgi/query-pr.cgi?pr=124985 - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEAREKAAYFAkhyRa0ACgkQwMJqmJVx9442QgCg2AjK428zBbh/KxEtrCVPee1q P80An0H65+EJ79ctx4YpycrwuOkwOttV =4zPQ -----END PGP SIGNATURE-----