From owner-svn-src-all@freebsd.org  Wed Dec 16 14:01:10 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40894A43A11;
 Wed, 16 Dec 2015 14:01:10 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com
 [IPv6:2607:f8b0:4001:c05::232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1025F1C86;
 Wed, 16 Dec 2015 14:01:10 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by mail-ig0-x232.google.com with SMTP id ph11so143243908igc.1;
 Wed, 16 Dec 2015 06:01:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=Sk04MCNj/+NgEiyT/s1DOYTI/2LpMYpwf8gnlBJrzmY=;
 b=J701NG6Et/OF/y0uWg4VPktyR/rymad7q0BCyFR3iDfqRqJ3Oq+H+PBmWpVNhR0H5Y
 HZ3OCmPzRSvV3lVMY3XfeqGdsVa4jlT5B314aDClZ4IOIvjQghUuoNP7H8NMvvbnF/L0
 N8ZHFn7qAG/IWgamfmI88tLGv0ax1KTTxh8UGDXmloOmnPUUUcsNcJiCb2CyQqS8Bbzw
 hQpZGCXowgT8NPiRc/j2CdionrF0FaFU9fv/qaKnRfjhjxnKX1adqdPrYYSKW4KqEfRk
 hxibzUY7T16RDJ7a5bAv7QmgIbiU16BtF4Uulijb5PPMwyYX/Vtn2JIOFsFN4Knwx5Sq
 vhSw==
X-Received: by 10.107.30.80 with SMTP id e77mr41582910ioe.180.1450274469527;
 Wed, 16 Dec 2015 06:01:09 -0800 (PST)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.142.69 with HTTP; Wed, 16 Dec 2015 06:00:50 -0800 (PST)
In-Reply-To: <201512160056.tBG0ujqA067178@repo.freebsd.org>
References: <201512160056.tBG0ujqA067178@repo.freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Wed, 16 Dec 2015 14:00:50 +0000
X-Google-Sender-Auth: 6VsT7E7gXMWTU9M5xrJBJVmmheA
Message-ID: <CAPyFy2CL6eX58AdKu74ShERTeZa-Sv9cgqowmvgT2899MrmfhA@mail.gmail.com>
Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp
 modules/tcp/fastpath netinet netinet/tcp_stacks
To: Randall Stewart <rrs@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2015 14:01:10 -0000

On 16 December 2015 at 00:56, Randall Stewart <rrs@freebsd.org> wrote:
> Author: rrs
> Date: Wed Dec 16 00:56:45 2015
> New Revision: 292309
> URL: https://svnweb.freebsd.org/changeset/base/292309
>
> Log:
>   First cut of the modularization of our TCP stack. Still
>   to do is to clean up the timer handling using the async-drain.
>   Other optimizations may be coming to go with this. Whats here
>   will allow differnet tcp implementations (one included).
>   Reviewed by:  jtl, hiren, transports
>   Sponsored by: Netflix Inc.
>   Differential Revision:        D4055

This broke at least powerpc builds:

/scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:148:
warning: redundant redeclaration of 'tcp_dooptions'
[-Wredundant-decls]
/scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:736: warning:
previous declaration of 'tcp_dooptions' was here
/scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:150:
warning: redundant redeclaration of 'tcp_dropwithreset'
[-Wredundant-decls]
/scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:738: warning:
previous declaration of 'tcp_dropwithreset' was here
/scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:152:
warning: redundant redeclaration of 'tcp_pulloutofband'
[-Wredundant-decls]
/scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:740: warning:
previous declaration of 'tcp_pulloutofband' was here
/scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:153:
warning: redundant redeclaration of 'tcp_xmit_timer'
[-Wredundant-decls]
/scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:741: warning:
previous declaration of 'tcp_xmit_timer' was here
...