From owner-cvs-all Wed Jun 26 16: 4:28 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 3976537B5AF; Wed, 26 Jun 2002 15:55:21 -0700 (PDT) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 7F4605361; Wed, 26 Jun 2002 23:59:10 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh-portable session.c References: <200206261417.g5QEHTjR074759@freefall.freebsd.org> <20020626152357.GA30110@nagual.pp.ru> From: Dag-Erling Smorgrav Date: 26 Jun 2002 23:59:09 +0200 In-Reply-To: <20020626152357.GA30110@nagual.pp.ru> Message-ID: Lines: 21 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" writes: > About PATH: it seems that you expect that setusercontext() will set it, > but setusercontext() can fail (its return code currently not checked, but > was checked in our old code). It leaves code flow with no PATH. Better to > set PATH before it & check its return code too. I am not sure about > failure reaction, it can be fatal or just warning. Yes, that's a good point. The original code also assumes setusercontext(3) will succeed, and copies the parent's PATH to the child - but if setusercontext(3) failed, PATH might be anything (what if sshd was started manually from a shell?) It should use a compiled-in fallback instead. > About TERM: see "term" variable in login.conf(5) - sshd must not override > it and follow the way login does. I disagree. The "term" variable is a fallback. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message