From owner-svn-src-all@FreeBSD.ORG  Thu Jun  4 08:29:44 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E5E1AD84;
 Thu,  4 Jun 2015 08:29:44 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com
 [IPv6:2607:f8b0:400d:c09::22b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A2EF119B4;
 Thu,  4 Jun 2015 08:29:44 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by qkx62 with SMTP id 62so20114314qkx.3;
 Thu, 04 Jun 2015 01:29:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Za5sZL92fz6NlQeBu9dcAVrigordperovlrhYV+GimI=;
 b=asdXgeVIEqOSj2Lq+E+5U6RgTzoo7DeklJEGpVI5phR1HW1KUoxN4e9e+04a1yRhlr
 3YEacffw4ZGkNVMWJXJMatEzcdvrtk7s0z9m+wXQzyTi1geiP2WejFSymEa9Dj/PwE3O
 Bq5H6ix9id9lRkDfkKJT3VVFdKd5pF+d5t09BXaSafcKhvI7iwt3LL9TP6Q63oRnAQIu
 myaRKBR3oT04gk170VfRx3LQLKJycwrrLGX53umOIrCyclUgj4NM6rW7nmNvxJEwJtTs
 mILbIcNxTDNdtIEU4b2GyHWd6Zh4Ogn6nxXo0MhvydbNVONF58Jet9GcdtiNfOQFTJ6u
 z/Mg==
MIME-Version: 1.0
X-Received: by 10.140.108.195 with SMTP id j61mr41368489qgf.83.1433406583808; 
 Thu, 04 Jun 2015 01:29:43 -0700 (PDT)
Received: by 10.140.98.73 with HTTP; Thu, 4 Jun 2015 01:29:43 -0700 (PDT)
In-Reply-To: <20150604074152.GZ2499@kib.kiev.ua>
References: <201506040244.t542ibW9051338@svn.freebsd.org>
 <20150604074152.GZ2499@kib.kiev.ua>
Date: Thu, 4 Jun 2015 01:29:43 -0700
Message-ID: <CAGHfRMBdY_LVqJXTbH9=4LkS2_KaajiMEeFcAOp80Yhes-bDbQ@mail.gmail.com>
Subject: Re: svn commit: r283974 - head/lib/libugidfw
From: NGie Cooper <yaneurabeya@gmail.com>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Marcelo Araujo <araujo@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 08:29:45 -0000

On Thu, Jun 4, 2015 at 12:41 AM, Konstantin Belousov
<kostikbel@gmail.com> wrote:
...
>> -     size = sizeof(rule);
>>       error = sysctl(name, len, NULL, NULL, &rule, 0);
> This is very strange chunk.  I suspect that the intent was to have 'size'
> as the sixth argument to the sysctl(3) call, or just have sizeof(rule)
> instead of 0.

Agreed.