From owner-svn-src-all@FreeBSD.ORG  Thu Jun  4 10:18:04 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2CC86426;
 Thu,  4 Jun 2015 10:18:04 +0000 (UTC)
 (envelope-from araujobsdport@gmail.com)
Received: from mail-ob0-x236.google.com (mail-ob0-x236.google.com
 [IPv6:2607:f8b0:4003:c01::236])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E32DE14CF;
 Thu,  4 Jun 2015 10:18:03 +0000 (UTC)
 (envelope-from araujobsdport@gmail.com)
Received: by obew15 with SMTP id w15so29163508obe.1;
 Thu, 04 Jun 2015 03:18:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=Wf5TTIR1flZORLtbOtK4GcS8RD4CaEv6pQEu59RbpYU=;
 b=mutnVuEf3yYPH00UOHf6sEGdQYzQYUymAbPGzoVV3jMVPAW2a78iVCwLx89KBRiXqv
 moMWZRw+WidE9nk2vNjTb97IOq+ryRIxjeSEJxBdBanWzpgjqeAVDqfCUHIKRka+ovo+
 +x/TB1iTBA1mY2LwtRP3C8yw3a4YzQmyGW6Q0l+04SEPw2qGAxPR8IANxBOau9JFH889
 fvfr+/qYf34EykULb/x84Yn4bNjk1RPmS3XOHsHfcYCQTFeOejLXc8tSA0KlQZxHuDlt
 YT6sHO3dskBMDAqAiRR0ZQxyWbXb/eS7zGG4voBKl/7DUAYKWV97o0qki5bcaz6Ql3yN
 LB0A==
MIME-Version: 1.0
X-Received: by 10.182.97.138 with SMTP id ea10mr31035258obb.11.1433413083089; 
 Thu, 04 Jun 2015 03:18:03 -0700 (PDT)
Received: by 10.202.11.193 with HTTP; Thu, 4 Jun 2015 03:18:03 -0700 (PDT)
Reply-To: araujo@FreeBSD.org
In-Reply-To: <CAGHfRMBdY_LVqJXTbH9=4LkS2_KaajiMEeFcAOp80Yhes-bDbQ@mail.gmail.com>
References: <201506040244.t542ibW9051338@svn.freebsd.org>
 <20150604074152.GZ2499@kib.kiev.ua>
 <CAGHfRMBdY_LVqJXTbH9=4LkS2_KaajiMEeFcAOp80Yhes-bDbQ@mail.gmail.com>
Date: Thu, 4 Jun 2015 18:18:03 +0800
Message-ID: <CAOfEmZhZYLoqp2dKg_y_sU_VN4dfG_m9EpmkV8PQyiatymgyhg@mail.gmail.com>
Subject: Re: svn commit: r283974 - head/lib/libugidfw
From: Marcelo Araujo <araujobsdport@gmail.com>
To: NGie Cooper <yaneurabeya@gmail.com>
Cc: Konstantin Belousov <kostikbel@gmail.com>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.20
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 10:18:04 -0000

2015-06-04 16:29 GMT+08:00 NGie Cooper <yaneurabeya@gmail.com>:

> On Thu, Jun 4, 2015 at 12:41 AM, Konstantin Belousov
> <kostikbel@gmail.com> wrote:
> ...
> >> -     size = sizeof(rule);
> >>       error = sysctl(name, len, NULL, NULL, &rule, 0);
> > This is very strange chunk.  I suspect that the intent was to have 'size'
> > as the sixth argument to the sysctl(3) call, or just have sizeof(rule)
> > instead of 0.
>
> Agreed.
>

Agreed too, I have open another review request, because I have double check
and there are some missing prototypes too.


Best,
-- 

-- 
Marcelo Araujo            (__)araujo@FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)