From owner-freebsd-current@FreeBSD.ORG Thu Sep 24 15:27:50 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A00021065670 for ; Thu, 24 Sep 2009 15:27:50 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id 4C3778FC14 for ; Thu, 24 Sep 2009 15:27:49 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id F10EAC42CA; Thu, 24 Sep 2009 17:26:48 +0200 (CEST) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id f2XJq3viyA-O; Thu, 24 Sep 2009 17:26:47 +0200 (CEST) Received: from [10.0.0.34] (cardhu.semihalf.com [213.17.239.108]) by smtp.semihalf.com (Postfix) with ESMTPSA id B324CC42C7; Thu, 24 Sep 2009 17:26:47 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1076) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes From: Rafal Jaworowski In-Reply-To: <20090923170852.GA1099@michelle.cdnetworks.com> Date: Thu, 24 Sep 2009 17:27:46 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <20090922235350.GB1520@michelle.cdnetworks.com> <97F7ED67-AB93-4897-893B-16D3B22F9EB3@semihalf.com> <4ABA2C08.3070504@semihalf.com> <20090923170852.GA1099@michelle.cdnetworks.com> To: pyunyh@gmail.com X-Mailer: Apple Mail (2.1076) Cc: Grzegorz Bernacki , current@freebsd.org Subject: Re: mge, mii/e1000phy X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2009 15:27:50 -0000 On 2009-09-23, at 19:08, Pyun YongHyeon wrote: > On Wed, Sep 23, 2009 at 04:09:12PM +0200, Grzegorz Bernacki wrote: >>>> From: Pyun YongHyeon >>>> Date: 23 wrze?nia 2009 01:53:50 CEST >>>> To: Kristof Provost >>>> Cc: current@freebsd.org >>>> Subject: Re: mge, mii/e1000phy >>>> Reply-To: pyunyh@gmail.com >>>> >>>>> - Forcing the mge driver to IFM_100_TX (in >>>>> mge_set_port_serial_control) >>>>> does work. The system manages to acquire a DHCP address. >>>> >>>> Would you also show me the output of "ifconfig -m mge0"? >>>> >>>> I'm not author of mge(4) so I'm not familiar with mge(4). But it >>>> seems that mge(4) lacks link state change handler. Normally NICs >>>> are required to reprogram MAC to match resolved speed/duplex/ >>>> flow-control of link when it know it established a valid link which >>>> is notified from mii(4). >>> >> >> Hi, >> >> You are right. Link state change handler is missing in mge(4) >> driver. It >> is on our TODO list for this driver and will be implemented soon. >> > > I've briefly looked over MV88F5182 opensource community > programmer's user guide and found that ENQ bit of TQC register > should be set again whenever link DOWN/UP event is detected which > in turn may complicate the driver as it may have to reset its > descriptor indexes. And I guess it's wrong to spin wait until link > is established in mge_init_locked(). The datasheet says Rx checksum > offloading capability but can't find more information for that. > Another nice looking feature that lacks in mge(4) would be > interrupt coalescing. And I guess interrupt coalescing feature > would give better performance than polling(4). Both interrupt coalescing and RX checksum calculation offload are already supported by the driver. Rafal