From owner-cvs-all Fri Oct 26 1:51: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from anchor-post-32.mail.demon.net (anchor-post-32.mail.demon.net [194.217.242.90]) by hub.freebsd.org (Postfix) with ESMTP id 9D52237B401; Fri, 26 Oct 2001 01:51:00 -0700 (PDT) Received: from [62.49.251.130] (helo=herring.nlsystems.com) by anchor-post-32.mail.demon.net with esmtp (Exim 2.12 #1) id 15x2ha-000L6r-0W; Fri, 26 Oct 2001 09:50:54 +0100 Received: from salmon.nlsystems.com (salmon [10.0.0.3]) by herring.nlsystems.com (8.11.2/8.11.2) with ESMTP id f9Q8nd715418; Fri, 26 Oct 2001 09:49:39 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Fri, 26 Oct 2001 09:47:37 +0100 (BST) From: Doug Rabson To: John Baldwin Cc: , Subject: Re: cvs commit: src/sys/dev/aac aac.c src/sys/dev/acpica/Osd OsdSchedule.c src/sys/dev/amr amr.c src/sys/dev/mly mly.c src/sys/kern subr_taskqueue.c src/sys/sys taskqueue.h In-Reply-To: <200110260632.f9Q6WLn96425@freefall.freebsd.org> Message-ID: <20011026094417.B549-100000@salmon.nlsystems.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 25 Oct 2001, John Baldwin wrote: > jhb 2001/10/25 23:32:21 PDT > > Modified files: > sys/dev/aac aac.c > sys/dev/acpica/Osd OsdSchedule.c > sys/dev/amr amr.c > sys/dev/mly mly.c > sys/kern subr_taskqueue.c > sys/sys taskqueue.h > Log: > Add locking to taskqueues. There is one mutex per task, one mutex per > queue, and a mutex to protect the global list of taskqueues. The only > visible change is that a TASK_DESTROY() macro has been added to mirror > the TASK_INIT() macro to destroy a task before it is free'd. > > Submitted by: Andrew Reiter Thats a lot of mutexes. Wouldn't it be better to use a mutex pool for tasks? That would avoid the need for TASK_DESTROY too. Tasks were intended to be extremely lightweight, small objects with a stable ABI. This also forces them to depend on the mutex ABI. -- Doug Rabson Mail: dfr@nlsystems.com Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message