From owner-cvs-all@FreeBSD.ORG  Fri Jan 11 17:13:09 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 269B216A41A;
	Fri, 11 Jan 2008 17:13:09 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 0466913C43E;
	Fri, 11 Jan 2008 17:13:08 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id BF8BF1A3C1A;
	Fri, 11 Jan 2008 09:10:08 -0800 (PST)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kib@freebsd.org>
Date: Fri, 11 Jan 2008 12:12:39 -0500
User-Agent: KMail/1.9.7
References: <200801111650.m0BGorhh009597@repoman.freebsd.org>
In-Reply-To: <200801111650.m0BGorhh009597@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801111212.40473.jhb@freebsd.org>
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/fdc fdc.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2008 17:13:09 -0000

On Friday 11 January 2008 11:50:53 am Konstantin Belousov wrote:
> kib         2008-01-11 16:50:53 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/fdc          fdc.c 
>   Log:
>   The wakeup() line from the rev. 1.319 is wrong and reintroduces
>   a panic race on module unload. The wakeup() is internal to
>   kproc_exit/kthread_exit. The correct fix is to fix the msleep() in
>   detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread.
>   
>   Noted and reviewed by:  jhb
>   Pointy hat to:  kib
>   MFC after:      1 week

Original pointy hat to:	jhb

As I missed updating the msleep() when I fixed the unload race the first
time around which lead to the hang seen in the original PR.

-- 
John Baldwin