From owner-freebsd-ports-bugs@freebsd.org Fri Sep 15 21:22:47 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D312DE0AF4E for ; Fri, 15 Sep 2017 21:22:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE75B7E344 for ; Fri, 15 Sep 2017 21:22:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8FLMlXR034714 for ; Fri, 15 Sep 2017 21:22:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 222358] Mk/bsd.port.mk: include /etc/ports.conf as a file to hold ports-specific settings Date: Fri, 15 Sep 2017 21:22:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: yasu@utahime.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 21:22:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222358 Bug ID: 222358 Summary: Mk/bsd.port.mk: include /etc/ports.conf as a file to hold ports-specific settings Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: yasu@utahime.org CC: freebsd-ports-bugs@FreeBSD.org Created attachment 186423 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D186423&action= =3Dedit patch file Writing ports-specific settings to /etc/make.conf is not good because such settings are also applied when you 'make' something that has nothing to with ports. There is a workaround to guard them as following: .if !empty(.CURDIR:M*usr/ports*) # settings that should be applied only for ports build. .endif But there is some cases that such a workaround does not work as expected. F= or example, 1. When /usr/ports is symbolic link to somewhere else and real path is somothing like /foo/bar/baz/portsdir. 2. When you decide to do some experiment, check out port tree to /some/where/temp/ports, cd to /some/where/temp/ports/category/portname, edit some files and try 'make PORTSDIR=3D/some/where/temp/ports'. By contrast including file for ports-specific settings from bsd.port.mk wor= ks well regardless of whether /usr/ports is symbolic link or not, whatever the real path of /usr/ports is and whatever value is set as PORTSDIR. And in addtion there is already similar best practice in base system, /etc/src.con= f. So I think this is better way to isolate ports-specific settings from other= s. --=20 You are receiving this mail because: You are on the CC list for the bug.=