From owner-cvs-all Fri Apr 27 18:30:16 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 0DF6137B423; Fri, 27 Apr 2001 18:30:04 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id A221A6ACBD; Sat, 28 Apr 2001 11:00:02 +0930 (CST) Date: Sat, 28 Apr 2001 11:00:02 +0930 From: Greg Lehey To: Brian Somers Cc: Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/vinum vinum.8 Message-ID: <20010428110002.O34609@wantadilla.lemis.com> References: <200104272136.f3RLa5M37024@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200104272136.f3RLa5M37024@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Fri, Apr 27, 2001 at 10:36:05PM +0100 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Friday, 27 April 2001 at 22:36:05 +0100, Brian Somers wrote: >> On Friday, 27 April 2001 at 3:32:49 -0700, Ruslan Ermilov wrote: >>> ru 2001/04/27 03:32:49 PDT >>> >>> Modified files: >>> sbin/vinum vinum.8 >>> Log: >>> mdoc(7) police: fix markup. >> >> Review rejected by: grog > > What's the problem with the change ? See my review message. Initially, the issue was that it hadn't been reviewed. The review showed a large number of problems. > The only thing that looks arguable is that they aren't backwards > compatible (more than 8 args stuff).... but such is the price of > progress. You sound like a Microsoft salesman: "Well, yes, it doesn't quite run your old games like the old one, but look at the snazzy GUI". In fact, I suspect that you're referring to a macro incompatibility here, and that it will go away. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message