From owner-freebsd-embedded@FreeBSD.ORG Fri Dec 23 22:18:35 2011 Return-Path: Delivered-To: embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 985B11065677 for ; Fri, 23 Dec 2011 22:18:35 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4D8B68FC1B for ; Fri, 23 Dec 2011 22:18:34 +0000 (UTC) Received: by vbbfr13 with SMTP id fr13so13495914vbb.13 for ; Fri, 23 Dec 2011 14:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=1elQSGkEH4UxuDYF7nEHwhdj7zkaTnaLNcXFlt5GHdg=; b=haN2EdnWIwDfGlrhGHx8ue8tPr4PhbwSxdqsuf06h/YsYKm0j2wdwvnq8Kn8LL9YZa /D8+YxC2K2LqhCWwyqRPiKjlnanwpjwHpijPL3liWpSOCttdNnOlYtH3AIGr7k10Cpx4 v2j5diNc37Qu49LC9Fi/brVfha65c9gex97hs= MIME-Version: 1.0 Received: by 10.52.33.99 with SMTP id q3mr8348442vdi.100.1324677314785; Fri, 23 Dec 2011 13:55:14 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Fri, 23 Dec 2011 13:55:14 -0800 (PST) In-Reply-To: <20111223173139.dd31e9cb.ray@freebsd.org> References: <20111223122947.4235c390.ray@freebsd.org> <1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0@lassitu.de> <20111223173139.dd31e9cb.ray@freebsd.org> Date: Fri, 23 Dec 2011 13:55:14 -0800 X-Google-Sender-Auth: bOg2KeK1Blo6icQ8Ssseprgvap0 Message-ID: From: Adrian Chadd To: Aleksandr Rybalko Content-Type: text/plain; charset=ISO-8859-1 Cc: embedded@freebsd.org, Stefan Bethke Subject: Re: geom_uncompress X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 22:18:35 -0000 Hi, Some more of my comments: * We can do a pass later on to integrate this stuff into the kernel better, including using a single crc32 function. * The style seems quite fine, except the '?0:1' bits - can you please expand that out with spaces and put them on a new line (as they're already pushing up against 78 characters) I really don't like the cute hack of "sh image.uzlma". :) The main problem I have with it is it really is only appropriate if you're mounting things as a R/O cd9660 format, and totally silly otherwise. Can we possibly remove that for now, and maybe you can add that as a "vendor customisation" in zrouter somehow? (eg creating another flag in the magic header or something?) Other than that, I'm happy to commit this whole thing to FreeBSD and sort out the mess after that. Adrian