From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Sep 26 02:50:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3FDAC1065676 for ; Sat, 26 Sep 2009 02:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 01ED48FC1B for ; Sat, 26 Sep 2009 02:50:02 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8Q2o1be057860 for ; Sat, 26 Sep 2009 02:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8Q2o1Tj057859; Sat, 26 Sep 2009 02:50:01 GMT (envelope-from gnats) Resent-Date: Sat, 26 Sep 2009 02:50:01 GMT Resent-Message-Id: <200909260250.n8Q2o1Tj057859@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nate Eldredge Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC10E106566B for ; Sat, 26 Sep 2009 02:47:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id CAE138FC23 for ; Sat, 26 Sep 2009 02:47:06 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n8Q2l6TH016331 for ; Sat, 26 Sep 2009 02:47:06 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n8Q2l6rH016330; Sat, 26 Sep 2009 02:47:06 GMT (envelope-from nobody) Message-Id: <200909260247.n8Q2l6rH016330@www.freebsd.org> Date: Sat, 26 Sep 2009 02:47:06 GMT From: Nate Eldredge To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/139148: multimedia/dvdauthor: progress estimation bug in dvdunauthor X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2009 02:50:02 -0000 >Number: 139148 >Category: ports >Synopsis: multimedia/dvdauthor: progress estimation bug in dvdunauthor >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Sep 26 02:50:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Nate Eldredge >Release: 7.1-RELEASE >Organization: >Environment: FreeBSD vulcan.lan 7.1-RELEASE-p4 FreeBSD 7.1-RELEASE-p4 #0: Tue Mar 24 08:55:08 PDT 2009 root@vulcan.lan:/usr/obj/usr/src/sys/VULCAN amd64 >Description: dvdunauthor, from the multimedia/dvdauthor port, attempts to estimate the time remaining as it unauthors each title of a DVD. Due to an integer overflow the times reported are bogus, often negative. >How-To-Repeat: Run dvdunauthor on a disc with a large title, and wait a few seconds. >Fix: Patch below. Patch attached with submission follows: --- work/dvdauthor-0.6.14/src/dvdunauthor.c 2009-09-25 19:41:37.000000000 -0700 +++ work-new/dvdauthor-0.6.14/src/dvdunauthor.c 2009-09-17 08:40:45.000000000 -0700 @@ -877,7 +877,7 @@ if( rl > BIGBLOCKSECT ) rl = BIGBLOCKSECT; now=times(&tp); if( now-start>3*clkpsec && numsect>0 ) { - int rmn=(totalsect-numsect)*(now-start)/(numsect*clkpsec); + int rmn=((long long)(totalsect-numsect))*(now-start)/(numsect*clkpsec); fprintf(stderr,"STAT: [%d] VOB %d, Cell %d (%d%%, %d:%02d remain)\r",i,cells[i].vob_id,cells[i].cell_id,(numsect*100+totalsect/2)/totalsect,rmn/60,rmn%60); } else fprintf(stderr,"STAT: [%d] VOB %d, Cell %d (%d%%)\r",i,cells[i].vob_id,cells[i].cell_id,(numsect*100+totalsect/2)/totalsect); >Release-Note: >Audit-Trail: >Unformatted: