From owner-freebsd-net Mon Oct 14 0:10:24 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 914DC37B401 for ; Mon, 14 Oct 2002 00:10:23 -0700 (PDT) Received: from mailhub.fokus.gmd.de (mailhub.fokus.gmd.de [193.174.154.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7791643E9E for ; Mon, 14 Oct 2002 00:10:22 -0700 (PDT) (envelope-from brandt@fokus.gmd.de) Received: from beagle (beagle [193.175.132.100]) by mailhub.fokus.gmd.de (8.11.6/8.11.6) with ESMTP id g9E7A4e25099; Mon, 14 Oct 2002 09:10:04 +0200 (MEST) Date: Mon, 14 Oct 2002 09:10:04 +0200 (CEST) From: Harti Brandt To: Luigi Rizzo Cc: "M. Warner Losh" , Subject: Re: Comments Please In-Reply-To: <20021012191709.B93684@carp.icir.org> Message-ID: <20021014090528.V19145-100000@beagle.fokus.gmd.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sat, 12 Oct 2002, Luigi Rizzo wrote: LR>On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote: LR>... LR>> : reveals the use of an explicit constant (6) in net/if_arp.h and LR>> : netinet/if_ether.c; there is more of the same in net/bridge.c LR>> : (my fault), net/if_atmsubr.c, netinet/if_ether.c, netncp/ncp_subr.c LR>> LR>> atmsubr? Doesn't ATM have its own constants? LR> LR>eh, that's the problem with explicit constants, you can never tell LR>whether "6" is english, german or italian... in any case the LR>relevant piece of code is: LR> LR> net/if_atmsubr.c: if (bcmp(alc, ATMLLC_HDR, 6)) { LR> LR>I have no idea if it has any relation with ethernet header sizes. No, this is the length of an LLC/SNAP header minus the type field. harti -- harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.gmd.de, brandt@fokus.fhg.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message