From owner-cvs-all  Mon Apr 23  3: 4:26 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF2DB37B42C; Mon, 23 Apr 2001 03:04:20 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA25276;
	Mon, 23 Apr 2001 20:04:14 +1000
Date: Mon, 23 Apr 2001 20:01:52 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Greg Lehey <grog@lemis.com>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_bmap.c cd9660_lookup.c
 cd9660_node.c cd9660_rrip.c cd9660_util.c cd9660_vfsops.c cd9660_vnops.c
In-Reply-To: <20010423190023.D37321@wantadilla.lemis.com>
Message-ID: <Pine.BSF.4.21.0104231939150.4878-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Mon, 23 Apr 2001, Greg Lehey wrote:

> On Monday, 23 April 2001 at 19:25:09 +1000, Bruce Evans wrote:
> > On Mon, 23 Apr 2001, Greg Lehey wrote:
> >> Well, it doesn't exactly seem to be correct to redefine AF_MAX in
> >> sys/mount.h to get around it.  But pass me the pointy hat: I checked
> >> with make world and forgot LINT.
> >
> > Defining AF_MAX in 2 places is easier than having a whole header just for
> > defining AF_MAX.  The definitions won't get out of sync, because building
> > kernels will give warnings about them being different, and committed code
> > doesn't cause warnings ;-).
> >
> > The include of <net/radix.h> is unrelated to this.  <net/radix.h> is already
> > ...
> 
> Good analysis.  You didn't answer the second part of my message:
> 
> > So what would you suggest?

Erm, just put things back like they used to be? :-)

> At the moment, GENERIC builds.  LINT doesn't.  I have the fixes to
> LINT ready to commit, but there's not much point if you think I should
> back all the crap out.

I don't think <net/radix.h> and <sys/socket.h> should be prerequisites for
<sys/mount.h>, especially new ones.  So please back it all out.

The netcred and netexport stuff may belong in a separate header.  struct
netexport doesn't seem to used outside of vfs_subr.c, and moving its
declaration there would eliminate AF_MAX from <sys/mount.h>.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message