From owner-freebsd-ports  Thu Aug  8  6:40:10 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9CCE737B400
	for <freebsd-ports@hub.freebsd.org>; Thu,  8 Aug 2002 06:40:03 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7113943E72
	for <freebsd-ports@hub.freebsd.org>; Thu,  8 Aug 2002 06:40:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g78De2JU035308
	for <freebsd-ports@freefall.freebsd.org>; Thu, 8 Aug 2002 06:40:02 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g78De28A035307;
	Thu, 8 Aug 2002 06:40:02 -0700 (PDT)
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B891E37B400
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Aug 2002 06:35:37 -0700 (PDT)
Received: from www.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7E99243E77
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Aug 2002 06:35:37 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.4/8.12.4) with ESMTP id g78DZbOT034288
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.4/8.12.4/Submit) id g78DZbjr034286;
	Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
Message-Id: <200208081335.g78DZbjr034286@www.freebsd.org>
Date: Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
From: Jens Rehsack <rehsack@liwing.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: ports/41447: Sablot 0.95 exports constants
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         41447
>Category:       ports
>Synopsis:       Sablot 0.95 exports constants
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 08 06:40:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Jens Rehsack
>Release:        4.6-STABLE
>Organization:
LiWing IT-Services
>Environment:
>Description:
The actualized sablot-port exports in sxpath.h some global constants.
This lacks C/C++ conventions who say it should be declared as
x.h:
const long int x;
x.c
const long int x = a;

This multiple export bugs if the header will included multiple times into object files of a library.
This happens in php4 - what causes my (wrong!) PR/41405.
>How-To-Repeat:
Build PHP4 with Sablot 0.95
>Fix:
--- src/engine/sxpath.h.orig	Thu Aug  8 12:59:11 2002
+++ src/engine/sxpath.h		Thu Aug  8 12:59:52 2002
@@ -66,9 +66,9 @@
 typedef void *QueryContext;
 
 /*option constants */
-const unsigned long SXPF_DISPOSE_NAMES = 1;
-const unsigned long SXPF_DISPOSE_VALUES = 2;
-const unsigned long SXPF_SUPPORTS_UNPARSED_ENTITIES = 4;
+#define SXPF_DISPOSE_NAMES 1
+#define SXPF_DISPOSE_VALUES 2
+#define SXPF_SUPPORTS_UNPARSED_ENTITIES 4
 
 /*
  *    DOM handler functions
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message