From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Sep 5 19:40:03 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6366D10656D8 for ; Sun, 5 Sep 2010 19:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 37B1C8FC12 for ; Sun, 5 Sep 2010 19:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o85Je3e7012159 for ; Sun, 5 Sep 2010 19:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o85Je3nx012158; Sun, 5 Sep 2010 19:40:03 GMT (envelope-from gnats) Date: Sun, 5 Sep 2010 19:40:03 GMT Message-Id: <201009051940.o85Je3nx012158@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Alex Samorukov Cc: Subject: Re: ports/150235: sysutils/smartmontools build system bug X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alex Samorukov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2010 19:40:03 -0000 The following reply was made to PR ports/150235; it has been noted by GNATS. From: Alex Samorukov To: Garrett Wollman Cc: bug-followup@FreeBSD.org, developers@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Date: Sun, 05 Sep 2010 21:28:31 +0200 On 09/05/2010 08:53 PM, Garrett Wollman wrote: > > >> Your commit will break smartmontools functionality, as i mentioned >> before. Thats why i`m against it. Try to read before posting. >> > What commit? I haven't committed anything. > Ok, proposed patch. Your proposed patch will break smartmontools functionality - thats why i`m not able to accept it. > >> The required file was never included in the /usr/include. And it was >> changed more then once from the beginning. >> > If anything in userland links against a kernel header, then that > header needs to be installed in /usr/include, end of story. > -I/usr/src/sys is never acceptable in userland code. > There is a number of ports using /usr/src, e.g. - linux_kdump or emulators/rtc. Please, do PR agains every port depending on source tree, i will not feel so alone in that case ;-) Once again - if i will remove this include it will break smarmontools functionality. Thats the end of the story. As port maintainer and smartmontools developer - i`m against this. Rewrite your patch or i will ask to close this PR as bogus. > Of course one needs to upgrade all ports in the middle of the upgrade > cycle, if one wishes to have a working system at the end of it -- > particularly in the case of something that uses CAMIOCOMMAND, which > does not have any backwards-compatibility mechanism (hmmm, another bug > here). > I`m always upgrading ports after system system update and never had a problems with this.