From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Mar 14 05:40:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CA7C1065671 for ; Fri, 14 Mar 2008 05:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ED41F8FC26 for ; Fri, 14 Mar 2008 05:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2E5e11i072891 for ; Fri, 14 Mar 2008 05:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2E5e165072890; Fri, 14 Mar 2008 05:40:01 GMT (envelope-from gnats) Resent-Date: Fri, 14 Mar 2008 05:40:01 GMT Resent-Message-Id: <200803140540.m2E5e165072890@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Scot Hetzel Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 554E4106566C for ; Fri, 14 Mar 2008 05:31:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 429418FC15 for ; Fri, 14 Mar 2008 05:31:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2E5SApC038167 for ; Fri, 14 Mar 2008 05:28:10 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m2E5SA5C038166; Fri, 14 Mar 2008 05:28:10 GMT (envelope-from nobody) Message-Id: <200803140528.m2E5SA5C038166@www.freebsd.org> Date: Fri, 14 Mar 2008 05:28:10 GMT From: Scot Hetzel To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/121687: [patch] comms/gnokii: several depencancy fixes X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2008 05:40:02 -0000 >Number: 121687 >Category: ports >Synopsis: [patch] comms/gnokii: several depencancy fixes >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Mar 14 05:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Scot Hetzel >Release: FreeBSD 8.0-CURRENT >Organization: >Environment: FreeBSD hp010 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sat Feb 16 06:42:46 CST 2008 root@hp010:/usr/src/sys/amd64/compile/DV8135NR amd64 >Description: When rebuilding comms/gnokii, I found that the port would fail to find libical.so.0. The reason for this failure is that the current ical port is installing the library as libical.so.27. I also had the devel/pcsc-lite port installed, and when I built comms/gnokii the configure script found the pcsc-lite library and compiled in support for PC/SC cards. Another thing I found annoying is the automatic dependency on MySQL and PostgresSQL. For instance, when the x11/kde3 is installed, it will pull in quite a few dependencies when installing the various ports that make up KDE. During the install, it will install both MySQL and PostgresSQL. A few ports down the road, it will build gnokii which will detect both *SQL ports are install, which causes gnokii to compile in support for both of them. I would prefer to have the ability to disable one or both automatic dependencies. >How-To-Repeat: Run `make config` and choose the MDNS_AVAHI option, then try to build the port. Install both MySQL and PostgresSQL, then build the port. It will have a dependency on both ports. >Fix: The attached patch fixes these dependency problems. Patch attached with submission follows: Index: comms/gnokii/Makefile =================================================================== RCS file: /home/ncvs/ports/comms/gnokii/Makefile,v retrieving revision 1.62 diff -u -r1.62 Makefile --- comms/gnokii/Makefile 16 Feb 2008 16:36:58 -0000 1.62 +++ comms/gnokii/Makefile 7 Mar 2008 13:57:11 -0000 @@ -42,7 +42,7 @@ .include -.if exists(${LOCALBASE}/lib/libical.so.0) +.if exists(${LOCALBASE}/lib/libical.so) WITH_ICAL= yes .endif @@ -50,8 +50,12 @@ WITH_USB= yes .endif +.if exists(${LOCALBASE}/lib/libpcsclite.so) && !defined(WITHOUT_PCSC) +WITH_PCSC= yes +.endif + .if defined(WITH_ICAL) -LIB_DEPENDS+= ical.0:${PORTSDIR}/devel/libical +LIB_DEPENDS+= ical.27:${PORTSDIR}/devel/libical .endif .if defined(WITH_USB) @@ -62,6 +66,14 @@ CONFIGURE_ARGS+= --disable-libusb .endif +.if defined(WITH_PCSC) +LIB_DEPENDS+= pcsclite.1:${PORTSDIR}/devel/pcsc-lite + +CONFIGURE_ARGS+= --enable-libpcsclite +.else +CONFIGURE_ARGS+= --disable-libpcsclite +.endif + # If smsd is enabled check if MySQL or PostgreSQL are installed and # build the modules, no switches to make this port build those, if # you want them, just install them before this port. The port will @@ -73,14 +85,14 @@ .else PLIST_SUB+= SMSD='' MAN8+= smsd.8 -.if exists(${LOCALBASE}/lib/mysql/libmysqlclient.so) +.if exists(${LOCALBASE}/lib/mysql/libmysqlclient.so) && !defined(WITHOUT_MYSQL) USE_MYSQL= yes PLIST_SUB+= MSM='' WITH_MYSQL= yes .else PLIST_SUB+= MSM='@comment ' .endif -.if exists(${LOCALBASE}/bin/psql) +.if exists(${LOCALBASE}/bin/psql) && !defined(WITHOUT_PGSQL) USE_PGSQL= yes PLIST_SUB+= PGM='' WITH_PGSQL= yes >Release-Note: >Audit-Trail: >Unformatted: