From owner-cvs-all Thu May 30 1:40:45 2002 Delivered-To: cvs-all@freebsd.org Received: from chiark.greenend.org.uk (chiark.greenend.org.uk [212.135.138.206]) by hub.freebsd.org (Postfix) with ESMTP id 8FFFB37B400; Thu, 30 May 2002 01:40:40 -0700 (PDT) Received: from fanf by chiark.greenend.org.uk with local (Exim 3.12 #1) id 17DLU8-0004oi-00 (Debian); Thu, 30 May 2002 09:40:40 +0100 Date: Thu, 30 May 2002 09:40:39 +0100 From: Tony Finch To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys gpt.h Message-ID: <20020530094039.B10098@chiark.greenend.org.uk> References: <200205300544.g4U5iN586002@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200205300544.g4U5iN586002@freefall.freebsd.org>; from marcel@FreeBSD.org on Wed, May 29, 2002 at 10:44:23PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, May 29, 2002 at 10:44:23PM -0700, Marcel Moolenaar wrote: > > o Remove GCC specific attribute packed. > o Add incomplete array padding. Note that the padding array you have added doesn't cover the padding in the struct that you are having trouble with: offsetof(struct gpt_hdr, padding) == sizeof(struct gpt_hdr), i.e. there are 4 bytes of padding before the incomplete array member. It's also a gratuitous C99ism -- a comment would be better. Tony. -- f.a.n.finch http://dotat.at/ FORTIES CROMARTY FORTH TYNE DOGGER: SOUTHWEST, BACKING SOUTH FOR A TIME, 4 OR 5, OCCASIONALLY 6. SHOWERS. GOOD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message