From owner-svn-src-all@freebsd.org Fri Apr 8 09:42:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3BD0B08C16; Fri, 8 Apr 2016 09:42:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F2C717E9; Fri, 8 Apr 2016 09:42:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u389gmvB074255 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 8 Apr 2016 12:42:48 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u389gmvB074255 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u389gmvS074254; Fri, 8 Apr 2016 12:42:48 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 8 Apr 2016 12:42:48 +0300 From: Konstantin Belousov To: Sepherosa Ziehau Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297699 - head/sys/dev/hyperv/vmbus Message-ID: <20160408094248.GM1741@kib.kiev.ua> References: <201604080920.u389KliR048702@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201604080920.u389KliR048702@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2016 09:42:55 -0000 On Fri, Apr 08, 2016 at 09:20:47AM +0000, Sepherosa Ziehau wrote: > Author: sephe > Date: Fri Apr 8 09:20:46 2016 > New Revision: 297699 > URL: https://svnweb.freebsd.org/changeset/base/297699 > > Log: > hyperv: Revert r297481 > > Use vm_guest == VM_GUEST_HV is not enough to determine whether FreeBSD > is running on Hyper-V or not. What a mess. Can you explain why ? VM_GUEST_HV is only set in inentify_hypervisor() when the vendor string explicitely contained 'Microsoft Hv'. How can this be mis-interpreted to be a Xen id ?