From owner-freebsd-bluetooth@FreeBSD.ORG Tue Mar 7 21:46:22 2006 Return-Path: X-Original-To: freebsd-bluetooth@freebsd.org Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E52816A420 for ; Tue, 7 Mar 2006 21:46:22 +0000 (GMT) (envelope-from plunky@rya-online.net) Received: from mail03.svc.cra.dublin.eircom.net (mail03.svc.cra.dublin.eircom.net [159.134.118.19]) by mx1.FreeBSD.org (Postfix) with SMTP id ADD4143D49 for ; Tue, 7 Mar 2006 21:46:21 +0000 (GMT) (envelope-from plunky@rya-online.net) Received: (qmail 73916 messnum 271382 invoked from network[83.70.176.191/unknown]); 7 Mar 2006 21:46:19 -0000 Received: from unknown (HELO rya-online.net) (83.70.176.191) by mail03.svc.cra.dublin.eircom.net (qp 73916) with SMTP; 7 Mar 2006 21:46:19 -0000 Received: (nullmailer pid 8757 invoked by uid 1000); Tue, 07 Mar 2006 21:45:48 -0000 Date: Tue, 7 Mar 2006 21:45:48 +0000 (GMT) To: Maksim Yevmenkin In-Reply-To: <440DEE78.5020500@savvis.net> References: <1141762244.118700.5588.nullmailer@galant.ukfsn.org> <440DEE78.5020500@savvis.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Message-Id: <1141767948.252179.12317.nullmailer@galant.ukfsn.org> From: Iain Hibbert Cc: freebsd-bluetooth@freebsd.org Subject: Re: whitespace X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2006 21:46:22 -0000 On Tue, 7 Mar 2006, Maksim Yevmenkin wrote: > of course. i will take patches from anybody (as long as it conforms to > style(9)) :) why do you even ask? :) Hey, maybe you are some kind of dragon? :) I just read this document though, and it seems that whitespace changes alone are not encouraged.. however, I got rid of them already in my porting, will see what other changes can be fed back.. In other news, some of what I said a few weeks ago is changed now, I put psm and channel into the sockaddr as it does look better than using setsockopt() for that. However, it still looks slightly different: struct sockaddr_bt { uint8_t bt_len; sa_family_t bt_family; bdaddr_t bt_bdaddr; uint16_t bt_psm; uint8_t bt_channel; }; ..because I am still using a single sockaddr type for all bluetooth family sockets. Protocols that dont use fields just ignore them, but if necessary for compatibility a #define can easily be used. iain