From owner-svn-src-all@FreeBSD.ORG Mon Jul 2 16:42:34 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8F19A1065670; Mon, 2 Jul 2012 16:42:34 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 497C08FC18; Mon, 2 Jul 2012 16:42:34 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so8460585pbb.13 for ; Mon, 02 Jul 2012 09:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:in-reply-to:mime-version:content-transfer-encoding :content-type:message-id:cc:x-mailer:from:subject:date:to; bh=ycvlWI19ysmYFiZHIoSDM5TKWqsr8sJV/nHTyPCJzFU=; b=nTAVUwO+f98M5jh4C3rQIbTKw4SarLoW5M1vHPjsJC9QWRA43hhNbnz3p+JxOVTKBD TZg+jkOnz5SFI1aVOck3R80skJMB92hpYmcG62Cum5npPyKJFfu2CXqf/d9KmLiVG0Lc xD+GP6z73s4qbR4Z9FO22Q8wE4F9cAmg//Mwz2Qs3qpJ4pghI6nkD2zWh3GUGk1IEW6q TTAAc+pf0XvccskwrwS4v596Z3KkK6w8a/o2eY6c6uw0hTpsbZZ2USXrRcYAGLbmRiBz WC+HDcmKGe0Hdf9nKnrlEPOXZ4AoKxkrzDQOxoH9yWSYIUi1lK3NdWJ/yJ5Aau/yheYK QujQ== Received: by 10.68.213.7 with SMTP id no7mr30592079pbc.3.1341247354074; Mon, 02 Jul 2012 09:42:34 -0700 (PDT) Received: from [10.71.80.97] (mobile-166-147-095-114.mycingular.net. [166.147.95.114]) by mx.google.com with ESMTPS id ot4sm13339516pbb.65.2012.07.02.09.42.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 02 Jul 2012 09:42:33 -0700 (PDT) References: <201207021528.q62FSoot078093@svn.freebsd.org> <2B78C1CB-FC64-4C78-94D1-B01F02C02D2D@xcllnt.net> In-Reply-To: <2B78C1CB-FC64-4C78-94D1-B01F02C02D2D@xcllnt.net> Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <5D283E88-BB45-4188-9EC4-7301A6232D01@gmail.com> X-Mailer: iPhone Mail (9B206) From: Garrett Cooper Date: Mon, 2 Jul 2012 09:42:24 -0700 To: Marcel Moolenaar Cc: "svn-src-head@FreeBSD.org" , Dag-Erling Sm?rgrav , Baptiste Daroussin , "src-committers@FreeBSD.org" , "svn-src-all@FreeBSD.org" Subject: Re: svn commit: r237997 - in head: tools/build/mk tools/build/options usr.sbin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 16:42:34 -0000 On Jul 2, 2012, at 9:32 AM, Marcel Moolenaar wrote: >=20 > On Jul 2, 2012, at 8:28 AM, Baptiste Daroussin wrote: >=20 >> Author: bapt >> Date: Mon Jul 2 15:28:50 2012 >> New Revision: 237997 >> URL: http://svn.freebsd.org/changeset/base/237997 >>=20 >> Log: >> New build KNOB: WITHOUT_PKGBOOTSTRAP to condition building of usr.sbin/pk= g >> Do not condition usr.sbin/pkg building on WITHOUT_PKGTOOLS anymore, so th= at users can >> remove the old pkg_* tools without removing the pkgng boostrap >=20 > Oh, and: >=20 >> Added: head/tools/build/options/WITHOUT_PKGBOOSTRAP >=20 > You have a typo in the options filename as well. >=20 > With all those mistakes and typos, I cannot escape the notion that this is= a > rushed commit or at least that it didn't get the attention it should have > gotten. Worse, it wasn't caught by your mentor. >=20 > des: please give reviews more attention > bapt: it sometimes helps to review your own patches as if they weren't you= rs. > you won't catch as much as a real 3rd party would, because they are > still your patches and you're bound to overlook stuff, but at least > you may catch some of the boneheaded stuff. The other thing is that src.conf(5) wasn't regenerated after the commit (the= knob and the src.conf commit should be done separately to as src.conf gener= ation is driven by $Revision$ in the knob file. Thanks, -Garrett=