From owner-cvs-all Sat Apr 28 5:52:39 2001 Delivered-To: cvs-all@freebsd.org Received: from mppsystems.com (mppsystems.com [208.210.148.205]) by hub.freebsd.org (Postfix) with ESMTP id 230BE37B422; Sat, 28 Apr 2001 05:52:29 -0700 (PDT) (envelope-from mpp@mppsystems.com) Received: (from mpp@localhost) by mppsystems.com (8.11.3/8.11.3) id f3SCpZZ56114; Sat, 28 Apr 2001 07:51:35 -0500 (CDT) (envelope-from mpp) Date: Sat, 28 Apr 2001 07:51:35 -0500 From: Mike Pritchard To: Brian Somers Cc: Greg Lehey , Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/vinum vinum.8 Message-ID: <20010428075135.B55634@mppsystems.com> References: <200104280315.f3S3Fk504631@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200104280315.f3S3Fk504631@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Sat, Apr 28, 2001 at 04:15:46AM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG OK, how about a cooling off period? As someone who has done a *LOT* of mdoc work, let me review the changes? You will have to give me 4 days or so due to my work schedule (sounds like a good cooling off period to me :-), and I will review what was done. And either have a counter-patch, or my comments. OK? -Mike On Sat, Apr 28, 2001 at 04:15:46AM +0100, Brian Somers wrote: > > On Friday, 27 April 2001 at 22:36:05 +0100, Brian Somers wrote: > > >> On Friday, 27 April 2001 at 3:32:49 -0700, Ruslan Ermilov wrote: > > >>> ru 2001/04/27 03:32:49 PDT > > >>> > > >>> Modified files: > > >>> sbin/vinum vinum.8 > > >>> Log: > > >>> mdoc(7) police: fix markup. > > >> > > >> Review rejected by: grog > > > > > > What's the problem with the change ? > > > > See my review message. Initially, the issue was that it hadn't been > > reviewed. The review showed a large number of problems. > > I haven't seen any review, so I can't comment. > > > > The only thing that looks arguable is that they aren't backwards > > > compatible (more than 8 args stuff).... but such is the price of > > > progress. > > > > You sound like a Microsoft salesman: "Well, yes, it doesn't quite run > > your old games like the old one, but look at the snazzy GUI". > > ?? More like ``here's a new game (vinum.8), it doesn't run on old > machines (groffs)''. > > > In fact, I suspect that you're referring to a macro incompatibility > > here, and that it will go away. > > I'm referring to the inability to nroff the -current man page - you > need the latest groff. > > > Greg > > -- > > Finger grog@lemis.com for PGP public key > > See complete headers for address and phone numbers > > -- > Brian > > Don't _EVER_ lose your sense of humour ! > -- Mike Pritchard mpp@FreeBSD.org or mpp@mppsystems.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message