From owner-freebsd-multimedia  Sat Mar 15 22:26:56 1997
Return-Path: <owner-multimedia>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id WAA10668
          for multimedia-outgoing; Sat, 15 Mar 1997 22:26:56 -0800 (PST)
Received: from rah.star-gate.com (rah.star-gate.com [204.188.121.18])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA10663
          for <multimedia@freebsd.org>; Sat, 15 Mar 1997 22:26:53 -0800 (PST)
Received: from rah.star-gate.com (localhost.star-gate.com [127.0.0.1]) by rah.star-gate.com (8.8.5/8.7.3) with ESMTP id WAA03904; Sat, 15 Mar 1997 22:26:51 -0800 (PST)
Message-Id: <199703160626.WAA03904@rah.star-gate.com>
X-Mailer: exmh version 1.6.9 8/22/96
To: Steve Passe <smp@csn.net>
cc: "Louis A. Mamakos" <louie@TransSys.COM>, multimedia@freebsd.org
Subject: Re: latest bt848 code 
In-reply-to: Your message of "Sat, 15 Mar 1997 23:10:09 MST."
             <199703160610.XAA23910@Ilsa.StevesCafe.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 15 Mar 1997 22:26:51 -0800
From: Amancio Hasty <hasty@rah.star-gate.com>
Sender: owner-multimedia@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

No,
bktr->bktr_cap_ctl is different than bktr->capcontrol.

capcontrol sets the dma registers
and bktr_cap_ctl sets the bt848 cap_ctl register.

Originally, I meant capcontrol to be bktr_cap_ctl and it is a typo
in the original driver. I will clean that up later.

If people are having problems applying  the patch I will be happy
to provide a tar ball.


	Amancio

>From The Desk Of Steve Passe :
> Hi,
> 
> > That's what I started with, to replace the version in the CVS repository.  
I
> > then applied your patch to brooktree848.c, and the result wouldn't 
> > compile due to an unknown symbol 'bktr_cap_ctl' in the bktr_reg_t typedef.
> > 
> > Perhaps there's part of your changes that didn't make it into the patch?  
> > Were there changes any of the other files?
> 
> not being setup to compile right now I am at a bit of a disadvantage,
> but looking at the patch file and brktree_reg.h:
> 
>          default:
> +               bktr->bktr_cap_ctl  = 0x13;
>                 bt848[0xdc] = 0x13;
>                       ^^^^
> 
> 265 % grep cap brktree_reg.h
>  ...
>     u_short     capcontrol;     /* reg 0xdc capture control */
>                                        ^^^^
> 
> I would guess you want to change all:
>  bktr->bktr_cap_ctl
> 
> to:
>  bktr->capcontrol
> 
> ie., the 4 places it was introduced by the patch.
> 
> --
> Steve Passe	| powered by
> smp@csn.net	|            Symmetric MultiProcessor FreeBSD
>