From owner-cvs-all Thu May 30 2:10:14 2002 Delivered-To: cvs-all@freebsd.org Received: from kayak.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by hub.freebsd.org (Postfix) with ESMTP id DC37F37B401; Thu, 30 May 2002 02:09:50 -0700 (PDT) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by kayak.xcllnt.net (8.11.6/8.11.4) with ESMTP id g4U99hJ67011; Thu, 30 May 2002 02:09:43 -0700 (PDT) (envelope-from marcel@kayak.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.3/8.12.3) with ESMTP id g4U99jGn008527; Thu, 30 May 2002 02:09:45 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.3/8.12.3/Submit) id g4U99iCK008526; Thu, 30 May 2002 02:09:44 -0700 (PDT) (envelope-from marcel) Date: Thu, 30 May 2002 02:09:44 -0700 From: Marcel Moolenaar To: Tony Finch Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys gpt.h Message-ID: <20020530090944.GB8405@dhcp01.pn.xcllnt.net> References: <200205300544.g4U5iN586002@freefall.freebsd.org> <20020530094039.B10098@chiark.greenend.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020530094039.B10098@chiark.greenend.org.uk> User-Agent: Mutt/1.3.99i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, May 30, 2002 at 09:40:39AM +0100, Tony Finch wrote: > On Wed, May 29, 2002 at 10:44:23PM -0700, Marcel Moolenaar wrote: > > > > o Remove GCC specific attribute packed. > > o Add incomplete array padding. > > Note that the padding array you have added doesn't cover the padding in > the struct that you are having trouble with: offsetof(struct gpt_hdr, > padding) == sizeof(struct gpt_hdr), i.e. there are 4 bytes of padding > before the incomplete array member. I checked with GCC and offsetof != sizeof. > It's also a gratuitous C99ism -- a comment would be better. I need to solve a problem, so there's nothing gratuitous about it. BTW: I think it's time you give it a rest. Your remarks just about now stopped being constructive. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message