From owner-freebsd-hackers Tue May 9 10:43:45 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA20486 for hackers-outgoing; Tue, 9 May 1995 10:43:45 -0700 Received: from inet-gw-1.pa.dec.com (inet-gw-1.pa.dec.com [16.1.0.22]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id KAA20480 for ; Tue, 9 May 1995 10:43:44 -0700 Received: from cs.weber.edu by inet-gw-1.pa.dec.com (5.65/24Feb95) id AA07801; Tue, 9 May 95 10:37:34 -0700 Received: by cs.weber.edu (4.1/SMI-4.1.1) id AA06995; Tue, 9 May 95 11:30:59 MDT From: terry@cs.weber.edu (Terry Lambert) Message-Id: <9505091730.AA06995@cs.weber.edu> Subject: Re: This one looks very very suspecious to me.... To: gj@FreeBSD.org Date: Tue, 9 May 95 11:30:58 MDT Cc: rgrimes%gndrsh.aac.dev.com@inet-gw-1.pa.dec.com, hackers%freebsd.org@inet-gw-1.pa.dec.com In-Reply-To: from "gj%pcs.dec.com@inet-gw-1.pa.dec.com" at May 9, 95 01:31:52 pm X-Mailer: ELM [version 2.4dev PL52] Sender: hackers-owner@FreeBSD.org Precedence: bulk > > /*if (devmem && kfd > 0) > > return (addr); > > /* > > EEEK! Boy, did I f*ck that up ! > > This should definitely be commented out, or even better, totally removed. > This is a left-over from when I ported gdb many moons ago and was trying > out various things. Seems to me there may be a few more corpses like this > laying around in gdb, but as long as they don't start to stink....:-) Standard practice is "#ifdef OMIT" or "#ifdef NOTDEF" or "#ifdef GARYJ". Since most compilers generate warnings but work anyway with tags following #endif, you can also make notes to yourself using warnings (assuming your code is otherwise warning free) by putting tags after "#else" or "#endif" ...for instance: #ifdef OMIT #endif /* OMIT*/ FIX_LATER Terry Lambert terry@cs.weber.edu --- Any opinions in this posting are my own and not those of my present or previous employers.